Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump proc-macro-crate to the latest version #4409

Merged
merged 6 commits into from
May 13, 2024
Merged

Bump proc-macro-crate to the latest version #4409

merged 6 commits into from
May 13, 2024

Conversation

tdimitrov
Copy link
Contributor

This PR bumps proc-macro-crate to the latest version.

In order to test a runtime from https://github.com/polkadot-fellows/runtimes/ with the latest version of polkadot-sdk one needs to use cargo vendor to extract all runtime dependencies, patch them by hand and then build the runtime.

However at the moment 'vendored' builds fail due to bkchr/proc-macro-crate#48. To fix this proc-macro-crate should be updated to version 3.0.1 or higher.

@tdimitrov tdimitrov added the R0-silent Changes should not be mentioned in any release notes label May 8, 2024
@tdimitrov tdimitrov mentioned this pull request May 8, 2024
Merged
@tdimitrov
Copy link
Contributor Author

multihash-derive@0.8.0 still depends on proc-macro-crate@1.3.0 but bumping the former will require updating litep2p and multiaddr. I don't think it's worth the risk so I am leaving it for now.

@tdimitrov tdimitrov marked this pull request as ready for review May 10, 2024 12:42
@tdimitrov tdimitrov requested a review from ggwpez May 10, 2024 12:42
@ggwpez
Copy link
Member

ggwpez commented May 13, 2024

bot update ui

@command-bot
Copy link

command-bot bot commented May 13, 2024

@ggwpez Unknown command "update". Refer to help docs and/or source code.

@ggwpez
Copy link
Member

ggwpez commented May 13, 2024

bot update-ui

@command-bot
Copy link

command-bot bot commented May 13, 2024 •
edited

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6186823 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-880d5c8d-232f-463a-8c2d-48ab9a941ecb to cancel this command or bot cancel to cancel all commands in this pull request.

@tdimitrov tdimitrov requested a review from a team as a code owner May 13, 2024 11:42
@command-bot
Copy link

command-bot bot commented May 13, 2024

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6186823 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6186823/artifacts/download.

@tdimitrov
Copy link
Contributor Author

bot update-ui

@command-bot
Copy link

command-bot bot commented May 13, 2024 •
edited

@ggwpez "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" (https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6188382) was cancelled in #4409 (comment)

@ggwpez
Copy link
Member

ggwpez commented May 13, 2024 •
edited

bot cancel
@tdimitrov i already called it again.

@ggwpez ggwpez enabled auto-merge May 13, 2024 12:30
@command-bot
Copy link

command-bot bot commented May 13, 2024

@tdimitrov Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6188382 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6188382/artifacts/download.

@ggwpez ggwpez added this pull request to the merge queue May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 13, 2024
@ggwpez ggwpez added this pull request to the merge queue May 13, 2024
Merged via the queue into master with commit fb7362f May 13, 2024
147 checks passed
@ggwpez ggwpez deleted the tsv-update-proc-macro-crate branch May 13, 2024 15:44
ordian added a commit that referenced this pull request May 14, 2024
@ordian
Merge branch 'master' into ao-statement-distribution-reenabling-prep
fe4ea5f 
* master:
  improve MockValidationDataInherentDataProvider to support async backing (#4442)
  Bump `proc-macro-crate` to the latest version (#4409)
  [ci] Run check-runtime-migration in GHA (#4441)
  prospective-parachains rework (#4035)
  [ci] Add forklift to GHA ARC (#4372)
  `CheckWeight` SE: Check for extrinsic length + proof size combined (#4326)
  Add generate and verify logic for `AncestryProof` (#4430)
  Rococo AH: undeploy trie migration (#4414)
  Remove `substrate-frame-cli` (#4403)
  migrations: `take()`should consume read and write operation weight (#4302)
  `remote-externalities`: store block header in snapshot (#4349)
  xcm-emlator: Use `BlockNumberFor` instead of `parachains_common::BlockNumber=u32` (#4434)
  Remove `pallet::getter` usage from authority-discovery pallet (#4091)
  Remove pallet::getter usage from pallet-contracts-mock-network (#4417)
  Add docs to request_core_count (#4423)
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request May 27, 2024
@tdimitrov @TomaszWaszczyk
Bump proc-macro-crate to the latest version (paritytech#4409)
1e39919 
This PR bumps `proc-macro-crate` to the latest version.

In order to test a runtime from
https://github.com/polkadot-fellows/runtimes/ with the latest version of
polkadot-sdk one needs to use `cargo vendor` to extract all runtime
dependencies, patch them by hand and then build the runtime.

However at the moment 'vendored' builds fail due to
bkchr/proc-macro-crate#48. To fix this
`proc-macro-crate` should be updated to version `3.0.1` or higher.

---------

Co-authored-by: command-bot <>
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@tdimitrov @hitchhooker
Bump proc-macro-crate to the latest version (paritytech#4409)
9198f33 
This PR bumps `proc-macro-crate` to the latest version.

In order to test a runtime from
https://github.com/polkadot-fellows/runtimes/ with the latest version of
polkadot-sdk one needs to use `cargo vendor` to extract all runtime
dependencies, patch them by hand and then build the runtime.

However at the moment 'vendored' builds fail due to
bkchr/proc-macro-crate#48. To fix this
`proc-macro-crate` should be updated to version `3.0.1` or higher.

---------

Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tdimitrov @ggwpez @bkchr