Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve MockValidationDataInherentDataProvider to support async backing #4442

Merged

Conversation

librelois
Copy link
Contributor

@librelois librelois commented May 13, 2024

Support async backing in --dev mode

This PR improve the relay mock MockValidationDataInherentDataProvider to mach expectations of async backing runtimes.

  • Add para_head in the mock relay proof
  • Add relay slot in the mock relay proof

fix #4437

@bkchr bkchr added the T0-node This PR/Issue is related to the topic “node”. label May 13, 2024
@bkchr
Copy link
Member

bkchr commented May 13, 2024

@librelois please fix the CI :D

@ggwpez ggwpez requested a review from alexggh May 13, 2024 15:42
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6191462

@librelois
Copy link
Contributor Author

@librelois please fix the CI :D

Done

@ggwpez ggwpez added this pull request to the merge queue May 13, 2024
Merged via the queue into paritytech:master with commit 594c3ed May 13, 2024
157 of 158 checks passed
@librelois librelois deleted the elois-relay-mock-async-backing branch May 14, 2024 09:31
ordian added a commit that referenced this pull request May 14, 2024
* master:
  improve MockValidationDataInherentDataProvider to support async backing (#4442)
  Bump `proc-macro-crate` to the latest version (#4409)
  [ci] Run check-runtime-migration in GHA (#4441)
  prospective-parachains rework (#4035)
  [ci] Add forklift to GHA ARC (#4372)
  `CheckWeight` SE: Check for extrinsic length + proof size combined (#4326)
  Add generate and verify logic for `AncestryProof` (#4430)
  Rococo AH: undeploy trie migration (#4414)
  Remove `substrate-frame-cli` (#4403)
  migrations: `take()`should consume read and write operation weight (#4302)
  `remote-externalities`: store block header in snapshot (#4349)
  xcm-emlator: Use `BlockNumberFor` instead of `parachains_common::BlockNumber=u32` (#4434)
  Remove `pallet::getter` usage from authority-discovery pallet (#4091)
  Remove pallet::getter usage from pallet-contracts-mock-network (#4417)
  Add docs to request_core_count (#4423)
AurevoirXavier pushed a commit to darwinia-network/polkadot-sdk that referenced this pull request May 23, 2024
…ng (paritytech#4442)

Support async backing in `--dev` mode

This PR improve the relay mock `MockValidationDataInherentDataProvider`
to mach expectations of async backing runtimes.

* Add para_head in the mock relay proof
* Add relay slot in the mock relay proof

fix paritytech#4437
AurevoirXavier pushed a commit to darwinia-network/polkadot-sdk that referenced this pull request May 23, 2024
…ing (paritytech#4442)

Support async backing in `--dev` mode

This PR improve the relay mock `MockValidationDataInherentDataProvider`
to mach expectations of async backing runtimes.

* Add para_head in the mock relay proof
* Add relay slot in the mock relay proof 

fix paritytech#4437
TomaszWaszczyk pushed a commit to TomaszWaszczyk/polkadot-sdk that referenced this pull request May 27, 2024
…ing (paritytech#4442)

Support async backing in `--dev` mode

This PR improve the relay mock `MockValidationDataInherentDataProvider`
to mach expectations of async backing runtimes.

* Add para_head in the mock relay proof
* Add relay slot in the mock relay proof 

fix paritytech#4437
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
…ing (paritytech#4442)

Support async backing in `--dev` mode

This PR improve the relay mock `MockValidationDataInherentDataProvider`
to mach expectations of async backing runtimes.

* Add para_head in the mock relay proof
* Add relay slot in the mock relay proof 

fix paritytech#4437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instantly seal parachain block with async backing
4 participants