Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Adapt to new CryptoStore api #2884

Closed
wants to merge 1 commit into from
Closed

Adapt to new CryptoStore api #2884

wants to merge 1 commit into from

Conversation

hirschenberger
Copy link
Contributor

companion PR for paritytech/substrate#8619

@hirschenberger hirschenberger mentioned this pull request Apr 14, 2021
Closed
@ordian
Copy link
Member

ordian commented Apr 14, 2021

the companion build check on substrate PR is failing, I believe you need to update
https://github.com/paritytech/grandpa-bridge-gadget/blob/d8f233a7f876712a5f0dc45aa893c91147518418/beefy-gadget/src/worker.rs#L201
as well

@ordian ordian added A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Apr 14, 2021
@hirschenberger
Copy link
Contributor Author

There's a PR pending paritytech/grandpa-bridge-gadget#148 (comment)

@hirschenberger
Copy link
Contributor Author

hirschenberger commented Apr 15, 2021 •
edited
Loading

It seems as if it's unclear how to resolve this gordic knot of dependencies. Maybe we can discuss in paritytech/grandpa-bridge-gadget#148

@bkchr bkchr closed this Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hirschenberger @ordian @bkchr