This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Disputes runtime #2947
Merged
Disputes runtime #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
the
A3-in_progress
|
Should be ready for a final review and merge. |
|
bot merge |
|
Waiting for commit status. |
|
Merge aborted: Checks failed for bb47ed4 |
|
bot merge |
|
Waiting for commit status. |
|
Bot will approve on the behalf of @rphmeier, since they are a team lead, in an attempt to reach the minimum approval count |
ghost
approved these changes
Jul 19, 2021
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Jul 20, 2021
* master: Update secp256k1 and remove unrequired usage (#3502) Bump libc from 0.2.91 to 0.2.98 (#3496) Bump slotmap from 1.0.2 to 1.0.5 (#3495) Gossip rebroadcast rate limiter (#3494) dependabot: ignore another git dep (#3493) add rustfmt toml (#3491) Disputes runtime (#2947) Bump async-process from 1.0.1 to 1.1.0 (#3122) remove the kubernetes helm chart (#3483) added pallet-proxy in rococo feature dependencies (#3486) Update BEEFY+MMR integration. (#3480) more verbose asserts (#3476) ci: use srtool-actions to build runtimes (#3423) overseer gen minor chore fixes (#3479)
stze
added
D1-audited 👍
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the core of the disputes runtime as per the implementers' guide.
The disputes module handles the import of conflicting statements, and provides slashing and rewarding interfaces for runtimes to fill out. In practice we will plug disputes into slashing/rewarding.
A dispute is unconfirmed until 1/3+ of validators have participated. Validators have a limit on how many unconfirmed disputes they are allowed to participate in. This prevents spam from colluding malicious validators disputing each other over non-existent parachain blocks. Disputes that time out while unconfirmed should lead to a minor punishment of the participating validators, making spam of the chain expensive to perform.
Disputes concerning parablocks included in the local chain are always confirmed.
A dispute is considered concluded either when it times out unconfirmed or when concluding either for or against the candidate. It is mildly punishable to be against a valid candidate, and very punishable to be for an invalid candidate. If participants act on both sides of the dispute, it's possible for the dispute to conclude in both directions. However, acting on both sides of the dispute raises the likelihood of being slashed substantially, so there is no incentive to do so.
This adds the disputes to all runtimes, but does not combine it with any slashing or rewarding logic. That is, the node-side code for engaging with disputes is not implemented, and the result of any dispute activated on any network right now will be a no-op until the code is combined with the staking system. Thus there is no downside to integrating the module immediately.