This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update BEEFY+MMR integration. #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@drahnr could please help fixing spellcheck https://gitlab.parity.io/parity/polkadot/-/jobs/1016684? |
Working on a spellcheck fixing manifest, WIP. For the particular CI failures:
should become
@ordian which is why the pass currently is |
tomusdrw
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D2-notlive 💤
PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
labels
Jul 15, 2021
svyatonik
approved these changes
Jul 16, 2021
philipstanislaus
approved these changes
Jul 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks 🙏
adoerr
approved these changes
Jul 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I did a smoke test with rococo-local
.
ordian
added a commit
that referenced
this pull request
Jul 20, 2021
* master: Update secp256k1 and remove unrequired usage (#3502) Bump libc from 0.2.91 to 0.2.98 (#3496) Bump slotmap from 1.0.2 to 1.0.5 (#3495) Gossip rebroadcast rate limiter (#3494) dependabot: ignore another git dep (#3493) add rustfmt toml (#3491) Disputes runtime (#2947) Bump async-process from 1.0.1 to 1.1.0 (#3122) remove the kubernetes helm chart (#3483) added pallet-proxy in rococo feature dependencies (#3486) Update BEEFY+MMR integration. (#3480) more verbose asserts (#3476) ci: use srtool-actions to build runtimes (#3423) overseer gen minor chore fixes (#3479)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D2-notlive 💤
PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we construct merkle trees for parachains and BEEFY validator set.
Note that the pallet code that previously was part of
common/src/mmr.rs
is now part of BEEFY repository (paritytech/grandpa-bridge-gadget#236)