This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
cargo: sync workspace members with dependencies #4579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Jan 6, 2022
bkchr
added
A2-insubstantial
ordian
approved these changes
Jan 13, 2022
Cargo.toml
Outdated
Comment on lines
105
to
116
| "bridges/bin/runtime-common", | ||
| "bridges/modules/dispatch", | ||
| "bridges/modules/grandpa", | ||
| "bridges/modules/messages", | ||
| "bridges/primitives/chain-rococo", | ||
| "bridges/primitives/chain-wococo", | ||
| "bridges/primitives/header-chain", | ||
| "bridges/primitives/message-dispatch", | ||
| "bridges/primitives/messages", | ||
| "bridges/primitives/polkadot-core", | ||
| "bridges/primitives/runtime", | ||
| "bridges/primitives/test-utils", |
There was a problem hiding this comment.
I'm not sure about bridges pallets as it's added as a subtree and was removed here last time by @HCastano
cc @svyatonik @acatangiu
There was a problem hiding this comment.
Yeah I already discussed this with @FlorianFranzen, but he still doesn't has removed them..
There was a problem hiding this comment.
Imo there's no harm in adding these crates to workspace - they're built with the code anyways. We should avoid adding all bridges/* crates - there are crates that shall not be built here (ideally we should remove them from the polkadot repo, but ...).
Wizdave97
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Feb 3, 2022
* cargo: sync workspace members with dependencies * Remove bridges stuff * Fix Co-authored-by: Bastian Köcher <info@kchr.de>
|
@bkchr Thank you, not sure why this dropped off my notifications. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syncs the workspace crates returned by
cargo metadatawith the crates insideCargo.toml, which resolves some issues I was having with naersk as well with some older lsp servers.