Move XCM runtime configurations into their own files #4644
Conversation
KiChjang
added
A0-please_review
|
We should do this for the runtime in general, across all the pallets. |
| SignedToAccountId32<Origin, AccountId, PolkadotNetwork>, | ||
| ); | ||
|
|
||
| impl pallet_xcm::Config for Runtime { |
There was a problem hiding this comment.
I would personally rather have this block in the main runtime file, and all the other noisy parameter_types! in a separate file. This allows you to quickly skim the runtime configs with 1 layer of observability and no further. For example, you will know the name of the type parameters, but not their value, and their name could already say a lot of about them.
But this format is also fine.
There was a problem hiding this comment.
i actually think this content in a separate file is the more natural thing to do. I think that we should make files where configurations with one another are relevant, so all democracy / governance configs in one file. But keep separate things which are not related
|
bot merge |
* Move XCM runtime configurations into their own files * Update copyright year * Fix compilation errors * Import XCM types in westend runtime unit tests
This is purely a refactoring of XCM config code.
Since misconfigured XCM settings easily causes attacks, I thought that it may be useful to move its configuration into its own file for easier auditing and maintainability.