This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@KiChjang acala use xcm-emulator which mock real runtime, so previous it use
kusama_runtime::XcmConfig
. as #4644 changed, we need makexcm_config
public, otherwise there're error like: modulexcm_config
is private.https://github.com/AcalaNetwork/Acala/blob/9dfa889afea18b4dbff49f3e7fef3e26064fcb91/runtime/integration-tests/src/relaychain/kusama_test_net.rs#L31-L34
the xcm-simulator in polkadot code base don't have this problem because it use mock XcmConfig. but parachain integration test need use real instead mock XcmConfig.
another question, should we move other xcm related config, such as
cumulus_pallet_xcm::Config
,cumulus_pallet_xcmp_queue::Config
,cumulus_pallet_dmp_queue::Config
to xcm_config? or just leave it alone?