Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

make xcm_config public #4731

Merged

Conversation

zqhxuyuan
Copy link
Contributor

@zqhxuyuan zqhxuyuan commented Jan 17, 2022

@KiChjang acala use xcm-emulator which mock real runtime, so previous it use kusama_runtime::XcmConfig. as #4644 changed, we need make xcm_config public, otherwise there're error like: module xcm_config is private.

https://github.com/AcalaNetwork/Acala/blob/9dfa889afea18b4dbff49f3e7fef3e26064fcb91/runtime/integration-tests/src/relaychain/kusama_test_net.rs#L31-L34

decl_test_relay_chain! {
	pub struct KusamaNet {
		Runtime = kusama_runtime::Runtime,
		XcmConfig = kusama_runtime::XcmConfig, // 🔥
		new_ext = kusama_ext(),
	}
}

the xcm-simulator in polkadot code base don't have this problem because it use mock XcmConfig. but parachain integration test need use real instead mock XcmConfig.

another question, should we move other xcm related config, such as cumulus_pallet_xcm::Config,cumulus_pallet_xcmp_queue::Config, cumulus_pallet_dmp_queue::Config to xcm_config? or just leave it alone?

@KiChjang KiChjang added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jan 17, 2022
@KiChjang
Copy link
Contributor

should we move other xcm related config, such as cumulus_pallet_xcm::Config,cumulus_pallet_xcmp_queue::Config, cumulus_pallet_dmp_queue::Config to xcm_config? or just leave it alone?

Yes, I simply haven't gotten around to it yet.

@KiChjang
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 9ce5f7e into paritytech:master Jan 17, 2022
@zqhxuyuan zqhxuyuan deleted the xcm_config_public branch January 18, 2022 00:10
Wizdave97 pushed a commit to ComposableFi/polkadot that referenced this pull request Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants