Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix Migrations for the upcoming release #4692

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Fix Migrations for the upcoming release #4692

merged 1 commit into from
Jan 13, 2022

Conversation

kianenigma
Copy link
Contributor

@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jan 11, 2022
@kianenigma kianenigma requested a review from bkchr January 11, 2022 08:34
@chevdor chevdor added this to the v0.9.16 milestone Jan 11, 2022
bkchr
bkchr approved these changes Jan 11, 2022
View reviewed changes
runtime/kusama/src/lib.rs
Comment on lines +3045 to +3046
let _ = Self::execute(true);
Ok(())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not return the result?

@emostov emostov mentioned this pull request Jan 13, 2022
Closed
@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 0c563b6 into master Jan 13, 2022
@paritytech-processbot paritytech-processbot bot deleted the kiz-fix-9.15 branch January 13, 2022 06:52
emostov added a commit that referenced this pull request Jan 13, 2022
@emostov
Line things up with #4692
de2767d
Wizdave97 pushed a commit to ComposableFi/polkadot that referenced this pull request Feb 3, 2022
@kianenigma @Wizdave97
Fix the migrations for upcoming release (paritytech#4692)
e9688ee
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
v0.9.16
Development

Successfully merging this pull request may close these issues.
4 participants
@kianenigma @andresilva @bkchr @chevdor