This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
remove duplicated arm and fix version index #6884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
previously approved these changes
Mar 15, 2023
bkchr
added
A2-insubstantial
xlc
changed the title
xlc
commented
Mar 15, 2023
|
@bkchr we need to adjust the label |
gavofyork
reviewed
Mar 15, 2023
KiChjang
approved these changes
Mar 15, 2023
|
Worth putting in a test? |
gavofyork
approved these changes
Mar 15, 2023
|
I can add some tests tomorrow |
KiChjang
approved these changes
Mar 16, 2023
|
bot merge |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@bkchr can you backport this to v0.9.38 and v0.9.39 |
It should already been worked on. |
coderobe
pushed a commit
that referenced
this pull request
Mar 17, 2023
* remove duplicated arm * annotate the version index * add tests * fmt
14 tasks
coderobe
pushed a commit
that referenced
this pull request
Mar 17, 2023
* remove duplicated arm * annotate the version index * add tests * fmt
coderobe
pushed a commit
that referenced
this pull request
Mar 17, 2023
* remove duplicated arm * annotate the version index * add tests * fmt
|
Can we check the labels please? it seems to introduce breaking changes |
ggwpez
added
T6-XCM
ordian
added a commit
that referenced
this pull request
Mar 21, 2023
* master: kusama: enable dispute slashes (#5974) Introduce OpenGov into Polkadot (#6701) introduce new well known key (#6915) [CI] Add bootnode checking CI jobs (#6889) Bump parity-db (#6921) Handling timers for repeat dispute participation requests (#6901) [Companion #13634] keystore overhaul (iter2) (#6913) tweak some pattern matches to address a new clippy warning Bump ci-linux image for rust 1.68 Revert "Update orchestra to the recent version (#6854)" (#6916) Deprecate Currency: Companion for #12951 (#6780) changelog: template fixup (#6907) [Companion #13615] Keystore overhaul (#6892) update weights (#6897) Fix approval voting test (#6898) parachains-runtime: Less cloning! (#6896) Testing Reversion Speed on Dispute Concluded Against (#6880) remove duplicated arm and fix version index (#6884)
ordian
added a commit
that referenced
this pull request
Mar 21, 2023
* master: kusama: enable dispute slashes (#5974) Introduce OpenGov into Polkadot (#6701) introduce new well known key (#6915) [CI] Add bootnode checking CI jobs (#6889) Bump parity-db (#6921) Handling timers for repeat dispute participation requests (#6901) [Companion #13634] keystore overhaul (iter2) (#6913) tweak some pattern matches to address a new clippy warning Bump ci-linux image for rust 1.68 Revert "Update orchestra to the recent version (#6854)" (#6916) Deprecate Currency: Companion for #12951 (#6780) changelog: template fixup (#6907) [Companion #13615] Keystore overhaul (#6892) update weights (#6897) Fix approval voting test (#6898) parachains-runtime: Less cloning! (#6896) Testing Reversion Speed on Dispute Concluded Against (#6880) remove duplicated arm and fix version index (#6884)
tgmichel
pushed a commit
to moonbeam-foundation/polkadot
that referenced
this pull request
Mar 23, 2023
* remove duplicated arm * annotate the version index * add tests * fmt # Conflicts: # xcm/Cargo.toml
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chatgpt tell me the second arm is unreachable
also explicitly annotate the version index and update the numbers to match xcm version
so the version index for each struct is the xcm version that struct is introduced