This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Revert default proof size back to 64 KB #7115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
added
A0-please_review
franciscoaguirre
approved these changes
Apr 22, 2023
kianenigma
approved these changes
Apr 22, 2023
|
Instead of random guessing, we should finally add some test based on the linked comment. |
|
I tested with chopsticks and I have been able to do a |
|
Thanks @girazoki for testing! I've also enhanced our unit test in the Kusama runtime to specifically check for cases like these so that we can catch problems similar to this way earlier in our development process. I've tested it so that the unit test actually fails when I set the |
bkchr
approved these changes
Apr 24, 2023
|
bot merge |
ordian
added a commit
that referenced
this pull request
Apr 26, 2023
* master: malus: dont panic on missing validation data (#6952) Offences Migration v1: Removes `ReportsByKindIndex` (#7114) Fix stalling dispute coordinator. (#7125) Fix rolling session window (#7126) [ci] Update buildah command and version (#7128) Bump assigned_slots params (#6991) XCM: Remote account converter (#6662) Rework `dispute-coordinator` to use `RuntimeInfo` for obtaining session information instead of `RollingSessionWindow` (#6968) Revert default proof size back to 64 KB (#7115)
ordian
added a commit
that referenced
this pull request
Apr 26, 2023
* master: (39 commits) malus: dont panic on missing validation data (#6952) Offences Migration v1: Removes `ReportsByKindIndex` (#7114) Fix stalling dispute coordinator. (#7125) Fix rolling session window (#7126) [ci] Update buildah command and version (#7128) Bump assigned_slots params (#6991) XCM: Remote account converter (#6662) Rework `dispute-coordinator` to use `RuntimeInfo` for obtaining session information instead of `RollingSessionWindow` (#6968) Revert default proof size back to 64 KB (#7115) update rocksdb to 0.20.1 (#7113) Reduce base proof size weight component to zero (#7081) PVF: Move PVF workers into separate crate (#7101) Companion for #13923 (#7111) update safe call filter (#7080) PVF: Don't dispute on missing artifact (#7011) XCM: Properly set the pricing for the DMP router (#6843) pvf: Update docs for PVF artifacts (#6551) Bump syn from 2.0.14 to 2.0.15 (#7093) Companion for substrate#13771 (#6983) Added Dwellir Nigeria bootnodes. (#7097) ...
KiChjang
added a commit
that referenced
this pull request
May 3, 2023
* Revert default proof size back to 64 KB * Fix test expectations * Enhance unit test * cargo fmt * Fix comment
KiChjang
added a commit
that referenced
this pull request
May 3, 2023
* Revert default proof size back to 64 KB * Fix test expectations * Enhance unit test * cargo fmt * Fix comment
KiChjang
added a commit
that referenced
this pull request
May 3, 2023
* Revert default proof size back to 64 KB * Fix test expectations * Enhance unit test * cargo fmt * Fix comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #7081 (comment), we did not actually need to set the
DEFAULT_PROOF_SIZEto 0 when we are converting from a V2 Transact to V3. 64 KB was good enough.