Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-run a red check on a last commit, after receiving approvals #121

Open
rzadp opened this issue May 17, 2024 · 0 comments
Open

Re-run a red check on a last commit, after receiving approvals #121

rzadp opened this issue May 17, 2024 · 0 comments

Comments

@rzadp
Copy link
Contributor

rzadp commented May 17, 2024

Current behaviour

  1. The user creates a PR, and receives approvals on it.
  2. The user pushes a commit.
  3. The bot produces a red check on that commit - to prevent merging unapproved changes (as expected).
  4. The PR receives approvals.
  5. The checks guarding the merge of the PR turn green.
  6. BUT, the check associated with the last commit is still red - showing older runs, before 4. approvals.

Example:

polkadot-fellows/runtimes#299

The checks are green in the end and the PR has been merged, but the checks appearing next to the last commit are still red:

Expected behaviour

  1. The checks next to the last commit should turn green after receiving approvals.

Perhaps we can request a re-run of that check? It should turn green then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant