Config option: Count author as reviewer #34
Assignees
Milestone
Comments
Bullrich
added a commit
that referenced
this issue
Aug 1, 2023
Resolves #6 ## Changes - Fixed validation of rules not setting default values. - Fixed basic rule amount of review to be a positive integer (min value 1) - Added a test to verify this - Implemented GitHub Action to run on Pull Requests. - Added a log which reports what teams and users are missing. - Fixed a bug where the approvals wasn’t being properly filtered. - Fixed a bug where the system asked the author to review the PR - Fixed the wrong default name of the config file - Was set to `review.yml` instead of `review-bot.yml` - Changed rule type validation to have forced string values. - Added logs which inform when a rule is running and if it fails. - Rules are executed in order, so the logs will always correspond to the current rule. - Created tickets #32, #33 and #34 as foreseeable problems. - Created utility method to concatenate two arrays and removing duplicates. - @mutantcornholio I don’t know if `EngAutomation/js` has this (or if we want to add it to it) - Fixed a bug where the users who had approved the PR was not caching. - Fixed a glitch where the required reviews could be 0 or a negative number. - Fixed a glitch where the rule type could be invalid.
Merged
Merged
Bullrich
added a commit
that referenced
this issue
Aug 28, 2023
Resolves #34 Created the option to count the author of a PR as an approval. In the case of the "normal" rules it doesn't change the logic. In the case of the "and-distinct" rule we have to decide if we filter the author from the PR on evaluation time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add a custom option per rule to count the author as a positive review if he belongs to the teams of reviewers
The text was updated successfully, but these errors were encountered: