Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a status check #33

Closed
Bullrich opened this issue Jul 26, 2023 · 2 comments · Fixed by #37
Closed

Create a status check #33

Bullrich opened this issue Jul 26, 2023 · 2 comments · Fixed by #37
Assignees
@Bullrich
Milestone
Project launch

Comments

@Bullrich
Copy link
Contributor

Bullrich commented Jul 26, 2023 •
edited
Loading

Create a status check and replaced it with every new run, so that we don’t have several actions running.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks

If we have several actions running (by different events) one can fail while the other one passes:
image

In this case, the first action fails as the PR didn't have enough commits, but passed on the review event as the pr was reviewed
@Bullrich Bullrich added this to the Project launch milestone Jul 26, 2023
@Bullrich Bullrich self-assigned this Jul 26, 2023
@Bullrich Bullrich mentioned this issue Jul 26, 2023
Merged
Bullrich added a commit that referenced this issue Aug 1, 2023
@Bullrich
implemented action on itself (#31)
4e7cc41 
Resolves #6 

## Changes
- Fixed validation of rules not setting default values.
- Fixed basic rule amount of review to be a positive integer (min value
1)
    - Added a test to verify this
- Implemented GitHub Action to run on Pull Requests.
- Added a log which reports what teams and users are missing.
- Fixed a bug where the approvals wasn’t being properly filtered.
- Fixed a bug where the system asked the author to review the PR
- Fixed the wrong default name of the config file
  - Was set to `review.yml` instead of `review-bot.yml`
- Changed rule type validation to have forced string values.
- Added logs which inform when a rule is running and if it fails.
- Rules are executed in order, so the logs will always correspond to the
current rule.
- Created tickets #32, #33 and #34 as foreseeable problems.
- Created utility method to concatenate two arrays and removing
duplicates.
- @mutantcornholio I don’t know if `EngAutomation/js` has this (or if we
want to add it to it)
- Fixed a bug where the users who had approved the PR was not caching.
- Fixed a glitch where the required reviews could be 0 or a negative
number.
- Fixed a glitch where the rule type could be invalid.
@Bullrich Bullrich mentioned this issue Aug 1, 2023
Merged
@Bullrich
Copy link
Contributor Author

Bullrich commented Aug 2, 2023

The status check details_url does not work with GitHub actions.

Change of plan, merge #26 with this ticket and generate the summary in the status check

@Bullrich
Copy link
Contributor Author

Bullrich commented Aug 2, 2023

Limitations discovered

When running from a GitHub action:

Bullrich added a commit that referenced this issue Aug 8, 2023
@Bullrich
Added status checks (#37)
a36f225 
Added ability to generate a status check and the ability to overwrite
the latest one.

This resolves #33 and closes #26 as it merged it into one ticket.

There are some limitations as we can not select the check suite that the
check will belong (see
#33 (comment)),
but the name will be constant, making it validable.
@Bullrich Bullrich mentioned this issue Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bullrich Bullrich

Labels
None yet
Projects
None yet
Milestone
Project launch
Development

Successfully merging a pull request may close this issue.

Added status checks paritytech/review-bot
1 participant
@Bullrich