Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented action on itself #31

Merged
merged 25 commits into from
Aug 1, 2023
Merged

implemented action on itself #31

merged 25 commits into from
Aug 1, 2023

Conversation

Bullrich
Copy link
Collaborator

@Bullrich Bullrich commented Jul 26, 2023

Resolves #6

This PR implements the GitHub action on itself (so we can test it every time!)

Until https://github.com/paritytech/internal_it/issues/205 is resolved, this PR should not be merged (and we need to update the keys and token generation step)

In the meanwhile, I added a temporary token (that expires in one week).

Changes

  • Fixed validation of rules not setting default values.
    • Fixed basic rule amount of review to be a positive integer (min value 1)
      • Added a test to verify this
  • Implemented GitHub Action to run on Pull Requests.
  • Added a log which reports what teams and users are missing.
  • Fixed a bug where the approvals wasn’t being properly filtered.
  • Fixed a bug where the system asked the author to review the PR
  • Fixed the wrong default name of the config file
    • Was set to review.yml instead of review-bot.yml
  • Changed rule type validation to have forced string values.
  • Added logs which inform when a rule is running and if it fails.
    • Rules are executed in order, so the logs will always correspond to the current rule.
  • Created tickets Validate that rules can not repeat names #32, Create a status check #33 and Config option: Count author as reviewer #34 as foreseeable problems.
  • Created utility method to concatenate two arrays and removing duplicates.
    • @mutantcornholio I don’t know if EngAutomation/js has this (or if we want to add it to it)
  • Fixed a bug where the users who had approved the PR was not caching.
  • Fixed a glitch where the required reviews could be 0 or a negative number.
  • Fixed a glitch where the rule type could be invalid.

@Bullrich Bullrich requested a review from a team as a code owner July 26, 2023 10:35
@Bullrich Bullrich self-assigned this Jul 26, 2023
mordamax
mordamax previously approved these changes Jul 26, 2023
mordamax
mordamax previously approved these changes Jul 26, 2023
mordamax
mordamax previously approved these changes Jul 26, 2023
@Bullrich Bullrich dismissed mordamax’s stale review August 1, 2023 10:03

He approved by my request, not becaused it was needed

@Bullrich Bullrich requested review from mordamax and rzadp August 1, 2023 10:36
@Bullrich
Copy link
Collaborator Author

Bullrich commented Aug 1, 2023

@paritytech/opstooling with the exception of this line the PR is ready for review.

I'll remove that line before merging.

Copy link
Contributor

@mutantcornholio mutantcornholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

@Bullrich Bullrich merged commit 4e7cc41 into main Aug 1, 2023
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement action on itself
4 participants