notify-reviewers when PR is green

[mordamax]

Context from matrix:

Gav:
I'd also like to see integration into a chat bot so that for PRs which have otherwise enough reviews but are blocked on locks-reviews, the relevant individuals are pinged in chat with a link and request to approve the PR

Basti:
If we do this, then there should be a way to say that a pr is ready for review. There are currently a lot of prs which are opened and then take quite a lot of time until they are finished

Gav:
that's why i say "which have otherwise enough reviews"
i.e. the PR should already have approvals from regular reviewers.
this should mostly prevent locks reviewers from being notified of notified half-finished PRs
if that's not enough, we can require everything else green and regular approvals, so it's literally the last blocker for the PR

[mutantcornholio]

I struggle to see how this is should be part of command-bot.
From the domain separation standpoint this belongs to pr-custom-review, as it operates the same vocabulary, and probably should be configured at the same place.
From the point of how it should be used, I also don't see command-bot as the place, as it's execution triggers are always manual, while here I see that reviewers should be pinged at the moment when all other required reviews are submitted (which is also monitored by pr-custom-review, and not by command-bot).

[Bullrich]

I have a suggestion for this.

It would a bit of planning to develop but would fulfill the requirements (and more)

Toast Matrix

When a user is requested for review, we can send him a DM with the information:

@user123 has requested your review in Example #12343

When a user reviews a PR, we can also send the author a DM:

@User321 has reviewed your pull request: Example #12343:

This is nice! Approved!

We could use Matrix Hookshots to connect the services.

It would work the same way as toast.ninja (they have a very good infographic, I recommend checking out their site)

The only problem would be connecting users who have different emails in their github account than in matrix, but we could either manually connect them or provide a button to connect the accounts.

This would allow users to be notified immediately when a user requests their reviews.

We should also set it up so it doesn't trigger when a PR is in draft mode.

Would this fulfill that requirement?

We could then add an option to either notify when the user post a message (/notify reviewers) or notify only the last reviewer?

[mordamax]

Since moving to monorepo and moving out runtimes (where PR reviews are assigned manually) - there's no such problem
Closing as not planned