Added rule type 'fellows' #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and removed the field of rank for non fellows
Removed the tests that evaluate the ranks from the other implementations as now they are only in the type fellows
It was becoming very extended, it was time to update it
mordamax
approved these changes
Sep 21, 2023
| @@ -33,11 +34,17 @@ export interface AndDistinctRule extends Rule { | |||
| reviewers: Reviewers[]; | |||
| } | |||
|
|
|||
| export interface FellowsRule extends Rule { | |||
| type: RuleTypes.Fellows; | |||
| minRank: number; | |||
There was a problem hiding this comment.
does it make sense to make this consistent - either camelCase or snake for config or there's some purpose?
There was a problem hiding this comment.
I would prefer camelCase. Would it be fine if I make a second PR moments after this renaming min_approvals to minApprovals?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new type of rule named
fellows.This rule has its own evaluation (currently, it is mostly a copy of the
basicevaluation). This is done so we can add special cases for rule, as suggested by @bkchr in polkadot-fellows/runtimes#31 (review).Removed all the ability to request a
rankin normal rules. I believe that this is better as we now separate the concerns and simplify logic. Theor,andandand-distinctrule didn't really apply on fellows because a higher ranking one belongs also to the lower echelons.This resolves #84 and allows us to experiment better.
Also, this is technically a breaking change, but it has never been applied on any system, so it wouldn't be breaking an existing system.