Add the type Fellows #84
Assignees
Comments
Bullrich
added a commit
that referenced
this issue
Sep 21, 2023
Created a new type of rule named `fellows`. This rule has its own evaluation (currently, it is mostly a copy of the `basic` evaluation). This is done so we can add special cases for rule, as _suggested by @bkchr in polkadot-fellows/runtimes#31 (review). Removed all the ability to request a `rank` in normal rules. I believe that this is better as we now separate the concerns and simplify logic. The `or`, `and` and `and-distinct` rule didn't really apply on fellows because a higher ranking one belongs also to the lower echelons. This resolves #84 and allows us to experiment better. Also, this is technically a breaking change, but it has never been applied on any system, so it wouldn't be breaking an existing system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add a type for rules named
fellowsand move the rank system to that type so we can have specific rules for that situation and enhance it as needed.Originally requested by @bkchr in polkadot-fellows/runtimes#31 (review)
The text was updated successfully, but these errors were encountered: