Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

nomination-pools: allow pool operators to manage claimable funds #11638

Closed
tugytur opened this issue Jun 10, 2022 · 7 comments · Fixed by #12608
Closed

nomination-pools: allow pool operators to manage claimable funds #11638

tugytur opened this issue Jun 10, 2022 · 7 comments · Fixed by #12608
Labels
J0-enhancement An additional feature request.

Comments

@tugytur
Copy link

tugytur commented Jun 10, 2022

Currently when someone joins a nomination pool they have to actively manage it by claiming rewards or increasing their bond.
From our experience delegators want to stake and forget. Depending on the complexity of the custody this would be a rather big burden.

It would be great if the pool operator could take over this task for their members.
A member could set a default action for claimable funds when joining a pool, increase_bond or withdraw_claimables and then anyone could trigger the event and pay the transaction fees. This would allow the pool operator to take over this task.

@kianenigma mentioned that this should generally be possible to add but for simplicity reasons it was kept the way it is.
This feature would make the staking experience more seamless.

@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Jun 10, 2022
@kianenigma
Copy link
Contributor

This sounds like a good improvement to explore! we will look into it.

@kianenigma kianenigma added J0-enhancement An additional feature request. and removed J2-unconfirmed Issue might be valid, but it’s not yet known. labels Aug 16, 2022
@kianenigma kianenigma moved this from Backlog to Sometime-soon in (Nominated) Proof of Stake Aug 16, 2022
@Doordashcon
Copy link
Contributor

Doordashcon commented Oct 26, 2022

Hello @kianenigma, from the issue description I gathered the following.

  1. Anyone that joins includes the initial depositor?
  2. Members who are already part of a pool need an extrinsic to set a claimable action.
  3. New members can set a claimable action upon joining a pool.
  4. This change won't be backward compatible.

Taking this on!

@kianenigma
Copy link
Contributor

cc @rossbulat please look into this.

@kianenigma
Copy link
Contributor

kianenigma commented Nov 6, 2022

Okay, my thoughts on this are:

The only reasonable action for you is that you will allow the pool operator to call bond_extra(BondExtra::Rewards) on your behalf, at any point in time. Seems safe to me, but there might be edge cases where the operator can abuse this.

This must be entirely optional. Existing pool members should not be affected by this.

We can explore doing this with a lazy migration, or else you need to be very careful in how you write the migration for this.

Thanks @Doordashcon for taking this on 💯

@rossbulat
Copy link

rossbulat commented Nov 7, 2022

This is a nice addition, but for many users it will be a fun experience to go back to the dashboard on a daily basis and discover and claim how much reward they've received. This also encourages more time on the dashboard & more engagement with the network. So adding this feature, although nice, potentially prohibits this positive user pattern & risks the user forgetting about checking Polkadot in the future.

@Doordashcon
Copy link
Contributor

Hopefully making this feature optional should mitigate this risk, I also think nominators would want to check the actions of their pool operators from time to time.

@kianenigma
Copy link
Contributor

indeed this should be option, and default is current behavior.

@github-project-automation github-project-automation bot moved this from ⌛️ Sometime-soon to ✅ Done in (Nominated) Proof of Stake Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants