Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix query_info and query_fee_details functions for unsigned extrinsics #10107

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

thiolliere
Copy link
Contributor

@thiolliere thiolliere commented Oct 27, 2021

related to #9791

unsigned extrinsics do not pay fee in transaction-payment pallet, therefore query_info and query_fee_details should return no fee for unsigned extrinsics.

@JoshOrndorff @crystalin

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Oct 27, 2021
@thiolliere thiolliere added B3-apinoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Oct 27, 2021
@thiolliere thiolliere added this to In progress in Runtime via automation Oct 27, 2021
@thiolliere thiolliere moved this from In progress to Please Review in Runtime Oct 27, 2021
@crystalin
Copy link
Contributor

Thank you @thiolliere for taking care of this :)

@bkchr bkchr requested a review from kianenigma October 29, 2021 17:08
Runtime automation moved this from Please Review to Needs Audit Oct 31, 2021
@shawntabrizi
Copy link
Member

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 794e9a9 into master Oct 31, 2021
@paritytech-processbot paritytech-processbot bot deleted the gui-fix-query-details branch October 31, 2021 10:36
Runtime automation moved this from Needs Audit to Done Oct 31, 2021
@shawntabrizi shawntabrizi moved this from Done to Archive in Runtime Nov 11, 2021
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants