This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Move EnsureOneOf into the dispatch.rs, make an interface more general #10379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Leshiy
force-pushed
the
move-or-gate
branch
2 times, most recently
from
bc031f2
to
b124b21
Compare
Mr-Leshiy
force-pushed
the
move-or-gate
branch
from
b124b21
to
8a8cd5d
Compare
bkchr
approved these changes
Nov 27, 2021
bkchr
added
A2-insubstantial
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
shawntabrizi
approved these changes
Nov 29, 2021
|
bot merge |
|
Error: Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first. The following errors might have affected the outcome of this attempt:
Merge failed. Check out the criteria for merge. If you're not meeting the approval count, check if the approvers are members of substrateteamleads or core-devs. |
KiChjang
approved these changes
Nov 29, 2021
|
Well, this is a bit awkward... the cumulus companion CI check is failing, because the cumulus PR requires changes from the polkadot companion PR, but the cumulus companion CI check doesn't use the polkadot companion to compile with the cumulus companion, sooo... wat do? |
|
@shawntabrizi , @KiChjang do I need to do any update here to fix it ? Or as I understood it is related to the another repositories ? |
|
the cumulus companion check is a bit broken. I think you are good @Mr-Leshiy. |
kianenigma
added
A1-onice
and removed
A2-insubstantial
|
bot merge |
|
Error: It's not possible to meet the minimal approval count of 1 in paritytech/cumulus#810 |
|
bot merge |
|
Error: It's not possible to meet the minimal approval count of 1 in paritytech/polkadot#4405 |
|
bot merge |
wischli
added a commit
to KILTprotocol/kilt-node
that referenced
this pull request
Feb 1, 2022
wischli
added a commit
to KILTprotocol/kilt-node
that referenced
this pull request
Feb 9, 2022
* chore: bump Polkadot dependencies to v0.9.16 * refactor: use AllPalletsWithSystem hook * chore: remove crowdloan pallet * fix: apply no DefaultAccount check * fix: switch to default MaxEncodedLen paritytech/substrate#10662 * fix: apply asset quota + runtime state_version quota: paritytech/substrate#10382 state: paritytech/substrate#9732 * fix: Preimage registrar and Scheduler integration Scheduler: paritytech/substrate#10356 OriginPriviligeCmp: paritytech/polkadot#4166 * fix: OrderedSet * fix: apply new fork_id to chainspecs paritytech/substrate#10463 * fix: apply no default account for SudoConfig * fix: apply name changes for GrandPa paritytech/substrate#10463 * fix: EnsureOneOf paritytech/substrate#10379 * fix: preimage weights * fix: parachain client * fix: clippy copied weights * fix: bump deps * tests: attempt staking fix * bench: attempt to fix default accountid for dids * fix: staking unit test pallet order execution * fix: did unit benchmarks * fix: fmt * fix: revert to old hook order execution * bench: run manually for preimage + scheduler * fix: only import TaskManager for try-runtime feature * fix: use correct scheduler migration + add logs * refactor: use explicit para runtime executors * fix: apply code review by @Diiaablo95 * chore: apply suggestion from @weichweich review * chore: bump deps * fix: deps
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
…paritytech#10379) * move EnsureOneOf into the dispatch.rs, make an interface more general * Update frame/support/src/traits/dispatch.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
AurevoirXavier
added a commit
to darwinia-network/darwinia-common
that referenced
this pull request
Sep 8, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…paritytech#10379) * move EnsureOneOf into the dispatch.rs, make an interface more general * Update frame/support/src/traits/dispatch.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
polkadot companion: paritytech/polkadot#4405
skip check-dependent-cumulus