This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Switch from pwasm-utils to wasm-instrument
#10680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
added
A0-please_review
athei
added a commit
to paritytech/wasm-utils
that referenced
this pull request
Jan 17, 2022
I created a successor crate with a proper crate name and without all the dead code. Substrate is switched to the new crate here: paritytech/substrate#10680
pepyakin
approved these changes
Jan 17, 2022
cmichi
approved these changes
Jan 17, 2022
|
bot merge |
athei
added a commit
to paritytech/wasm-utils
that referenced
this pull request
Jan 17, 2022
I created a successor crate with a proper crate name and without all the dead code. Substrate is switched to the new crate here: paritytech/substrate#10680
niklasad1
added a commit
that referenced
this pull request
Jan 28, 2022
This reverts commit e2d1f18.
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Switch executor to wasm-instrument * Switch pallet-contracts to wasm-instrument
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Switch executor to wasm-instrument * Switch pallet-contracts to wasm-instrument
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crate
pwasm-utilscontains a lot of unused code and us largely unmaintained. The only parts of it that are in production use (by parity) is the stack height metering and gas instrumentation. All the "optimization" parts and CLI utils are provided bybinaryen.For that reason I created a new repository where I removed all the unused functionality and cleaned up the documentation. The old repository should be archived after we made the switch with substrate.
This PR switches to the new crate
wasm-instrument. No functionality changes where made when cleaning up the code.