Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Allow the treasury to have a maximum bound on the bond #10689

Merged
merged 2 commits into from Jan 19, 2022
Merged

Allow the treasury to have a maximum bound on the bond #10689

merged 2 commits into from Jan 19, 2022

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented Jan 18, 2022 •
edited

Polkadot companion: paritytech/polkadot#4739

Allow the treasury to have an upper limit to the size of bond required for proposals.

@gavofyork gavofyork added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jan 18, 2022
@gavofyork gavofyork added this to In progress in Runtime via automation Jan 18, 2022
@gavofyork
Copy link
Member Author

CC @rrtti

KiChjang
KiChjang reviewed Jan 18, 2022
View reviewed changes
frame/treasury/src/lib.rs Outdated Show resolved Hide resolved
shawntabrizi
shawntabrizi reviewed Jan 18, 2022
View reviewed changes
docs/Upgrading-2.0-to-3.0.md
@@ -199,6 +199,7 @@ As mentioned above, Bounties, Tips and Lottery have been extracted out of treasu
type OnSlash = ();
type ProposalBond = ProposalBond;
type ProposalBondMinimum = ProposalBondMinimum;
type ProposalBondMaximum = ();
type SpendPeriod = SpendPeriod;
type Burn = Burn;
+ type BurnDestination = ();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this an actual + sign in the text?

Runtime automation moved this from In progress to Needs Audit Jan 18, 2022
@gavofyork @KiChjang
Update frame/treasury/src/lib.rs
b9efe6c 
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
@gavofyork gavofyork merged commit fed456f into master Jan 19, 2022
@gavofyork gavofyork deleted the gav-treasury-max-bond branch January 19, 2022 14:08
Runtime automation moved this from Needs Audit to Done Jan 19, 2022
@shawntabrizi shawntabrizi moved this from Done to Archive in Runtime Jan 20, 2022
@ghzlatarev ghzlatarev mentioned this pull request Feb 2, 2022
Merged
26 tasks
@librelois librelois mentioned this pull request Feb 7, 2022
Closed
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
@gavofyork @KiChjang @grishasobol
Allow the treasury to have a maximum bound on the bond (paritytech#10689
8409dd9 
)

* Allow the treasury to have a maximum bound on the bond

* Update frame/treasury/src/lib.rs

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
AurevoirXavier added a commit to darwinia-network/darwinia-common that referenced this pull request Sep 14, 2022
@AurevoirXavier
Companion of paritytech/substrate#10689, !
bb6a778
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@gavofyork @KiChjang @ark0f
Allow the treasury to have a maximum bound on the bond (paritytech#10689
ebe266f 
)

* Allow the treasury to have a maximum bound on the bond

* Update frame/treasury/src/lib.rs

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>

Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KiChjang KiChjang KiChjang left review comments

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@kianenigma kianenigma kianenigma approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gavofyork @shawntabrizi @KiChjang @kianenigma