This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
remote ext: make it possible to use an existing ws connection #10737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
A3-in_progress
niklasad1
added
A0-please_review
niklasad1
commented
Jan 26, 2022
kianenigma
reviewed
Jan 26, 2022
kianenigma
approved these changes
Jan 26, 2022
emostov
approved these changes
Jan 28, 2022
|
bot merge |
paritytech-processbot
bot
deleted the
na-remote-externalities-from-ws-client
branch
Wizdave97
pushed a commit
to ComposableFi/substrate
that referenced
this pull request
Feb 4, 2022
…tech#10737) * remote ext: make it possible to pass ws client * grumbles: introduce `map_uri`
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
…tech#10737) * remote ext: make it possible to pass ws client * grumbles: introduce `map_uri`
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…tech#10737) * remote ext: make it possible to pass ws client * grumbles: introduce `map_uri`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced an
enum Transportto decide whether to use aexisting connectionorcreate a new connection URIThe logic should be kept but after the ws connection is established the
URIshouldn't be needed AFAIU, thus the enum.