Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Grandpa revert procedure #11162

Merged
merged 4 commits into from Apr 6, 2022
Merged

Grandpa revert procedure #11162

merged 4 commits into from Apr 6, 2022

Conversation

davxy
Copy link
Member

@davxy davxy commented Apr 4, 2022 •
edited

Partially addresses #10962

Implementation of revert method for GRANDPA consensus.

In practice, this procedure:

  • Removes standard authority changes nodes that were announced after the revert point
  • Removes forced authority changes elements that were announced after the revert point
  • Resets the voting round state

@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Apr 4, 2022
@davxy davxy added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Apr 4, 2022
@davxy davxy marked this pull request as ready for review April 4, 2022 10:07
@davxy davxy requested a review from andresilva as a code owner April 4, 2022 10:07
@davxy davxy requested a review from a team April 4, 2022 10:08
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Apr 4, 2022
@davxy davxy requested a review from bkchr April 4, 2022 10:08
andresilva
andresilva approved these changes Apr 6, 2022
View reviewed changes
client/finality-grandpa/src/authorities.rs Outdated Show resolved Hide resolved
@davxy @andresilva
Update client/finality-grandpa/src/authorities.rs
176ea30 
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
@davxy davxy merged commit c4dd1be into master Apr 6, 2022
@davxy davxy deleted the davxy-grandpa-revert branch April 6, 2022 14:23
@davxy davxy mentioned this pull request Apr 6, 2022
Closed
@notlesh notlesh mentioned this pull request Apr 28, 2022
Merged
12 tasks
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
@davxy @andresilva @DaviRain-Su
Grandpa revert procedure (paritytech#11162)
b085494 
* Grandpa revert procedure

* Trigger ci pipeline

* Test rename

* Update client/finality-grandpa/src/authorities.rs

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
@davxy davxy mentioned this pull request Nov 2, 2022
Merged
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@davxy @andresilva @ark0f
Grandpa revert procedure (paritytech#11162)
1cb33d1 
* Grandpa revert procedure

* Trigger ci pipeline

* Test rename

* Update client/finality-grandpa/src/authorities.rs

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

@wigy-opensource-developer wigy-opensource-developer wigy-opensource-developer approved these changes

@bkchr bkchr Awaiting requested review from bkchr

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davxy @andresilva @wigy-opensource-developer