Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Change default execution strategies to Wasm #11170

Merged
merged 1 commit into from Apr 6, 2022

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Apr 5, 2022

This pr changes all default execution strategies to Wasm. This is basically a deprecation of the
native runtime. While the native runtime isn't removed and can still be used, it will not be used
anymore by default.

This will also improve the usage for people who want to run random commits, which most often forget
to run with --execution wasm. Otherwise they often run into storage root mismatches because of
using the native runtime.

This pr changes all default execution strategies to `Wasm`. This is basically a deprecation of the
native runtime. While the native runtime isn't removed and can still be used, it will not be used
anymore by default.

This will also improve the usage for people who want to run random commits, which most often forget
to run with `--execution wasm`. Otherwise they often run into storage root mismatches because of
using the native runtime.
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes B5-clientnoteworthy C1-low PR touches the given topic and has a low impact on builders. labels Apr 5, 2022
@bkchr bkchr requested a review from a team April 5, 2022 20:20
Copy link
Contributor

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we also using wasmtime by default?

Copy link
Contributor

@wigy-opensource-developer wigy-opensource-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README of staking-miner might need some fixup in the "Testing locally" section, too? And the bridges repo also overrides --execution in the compose files.

@bkchr
Copy link
Member Author

bkchr commented Apr 6, 2022

Are we also using wasmtime by default?

If the feature is enabled, yes.

@bkchr
Copy link
Member Author

bkchr commented Apr 6, 2022

The README of staking-miner might need some fixup in the "Testing locally" section, too? And the bridges repo also overrides --execution in the compose files.

This doesn't break anything, it just changes the default. You can still use the cli argument to override these values.

@bkchr bkchr merged commit 3cad018 into master Apr 6, 2022
@bkchr bkchr deleted the bkchr-execution-strategy-wasm branch April 6, 2022 07:55
@xlc
Copy link
Contributor

xlc commented Apr 6, 2022

I will assume parachains doesn't need to do anything and will inherent this default once we upgrade Substrate version?

@bkchr
Copy link
Member Author

bkchr commented Apr 6, 2022

Exactly. These are the default values for the cli flags. As long as you don't run your node with any --execution* flag, this will be picked up.

@bLd75
Copy link

bLd75 commented Apr 25, 2022

Just a point worst mentioning: wasm strategy drastically reduces performance of archive nodes who have public exposed endpoint under high number of requests.
Archive nodes will have to explicitly set native execution.

DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
This pr changes all default execution strategies to `Wasm`. This is basically a deprecation of the
native runtime. While the native runtime isn't removed and can still be used, it will not be used
anymore by default.

This will also improve the usage for people who want to run random commits, which most often forget
to run with `--execution wasm`. Otherwise they often run into storage root mismatches because of
using the native runtime.
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
This pr changes all default execution strategies to `Wasm`. This is basically a deprecation of the
native runtime. While the native runtime isn't removed and can still be used, it will not be used
anymore by default.

This will also improve the usage for people who want to run random commits, which most often forget
to run with `--execution wasm`. Otherwise they often run into storage root mismatches because of
using the native runtime.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants