Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

BABE: Fix aux data cleaning (#11263) #11276

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Commits on Apr 25, 2022

  1. BABE: Fix aux data cleaning (#11263)

    With the latest optimizations of the `FinalityNotification` generation, the aux data pruning started
    to print a warning. The problem here was that we printed a warning and stopped the adding of blocks
    to prune when we hit the `heigh_limit`. This is now wrong, as we could for example have two 512 long
    forks and then we start finalizing one of them. The second fork head would be part of the stale
    heads at some point (in the current implementation when we finalize second fork head number + 1),
    but then we would actually need to go back into the past than `heigh_limit` (which was actually
    last_finalized - 1). We now go back until we reach the canonical chain.
    
    Also fixed some wrong comment that was added by be about the content of the `finalized` blocks in
    the `FinalityNotification`.
    bkchr authored and chevdor committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    b789fb3 View commit details
    Browse the repository at this point in the history