This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add more events to nomination pools #11343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kianenigma
commented
May 3, 2022
kianenigma
commented
- emit an event when member is removed
- only emit payout event if amount is non-zero.
- fix a bug that would prematurely kill an account when their active points would go to zero: correct is to kill them when their total points go to zero.
- fix a bug where permission-less unbond was allowed to be partial - this allows an attacker to create a large number of epsilon unlock chunks for anyone who can be permissionlessly unbonded and clog the system.
- added new tests and events to some of the tests that help identify such issues.
kianenigma
added
A0-please_review
shawntabrizi
reviewed
May 3, 2022
shawntabrizi
approved these changes
May 3, 2022
bkchr
approved these changes
May 3, 2022
|
bot merge |
|
Waiting for commit status. |
|
bot merge |
jakoblell
added
D1-audited 👍
kianenigma
changed the title
godcodehunter
pushed a commit
to sensoriumxr/substrate
that referenced
this pull request
Jun 22, 2022
* fix a few things with nomination pools * fix typo * fix build * add missing try-runtime feat
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
* fix a few things with nomination pools * fix typo * fix build * add missing try-runtime feat
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* fix a few things with nomination pools * fix typo * fix build * add missing try-runtime feat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.