Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

BlockId::Number refactor: trivial changes to BlockId::Hash #12471

Merged
merged 3 commits into from
Oct 12, 2022
Merged

BlockId::Number refactor: trivial changes to BlockId::Hash #12471

merged 3 commits into from
Oct 12, 2022

Conversation

michalkucharczyk
Copy link
Contributor

@michalkucharczyk michalkucharczyk commented Oct 11, 2022 •
edited

It changes all the usages of BlockId::Number to BlockId::Hash wherever such change was trivial.

This PR is part of BlockId::Number refactoring analysis (#11292) .

@michalkucharczyk michalkucharczyk added the A3-in_progress Pull request is in progress. No review needed at this stage. label Oct 11, 2022
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Oct 11, 2022
@michalkucharczyk michalkucharczyk added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit and removed A0-please_review Pull request needs code review. labels Oct 11, 2022
@michalkucharczyk michalkucharczyk added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Oct 11, 2022
@bkchr bkchr requested a review from a team October 12, 2022 12:37
@michalkucharczyk michalkucharczyk changed the title BlockId::Number refactor: trivial changes to BloclId::Hash BlockId::Number refactor: trivial changes to BlockId::Hash Oct 12, 2022
@michalkucharczyk
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit f8a0b7a into master Oct 12, 2022
@paritytech-processbot paritytech-processbot bot deleted the mku-blockid-analysis branch October 12, 2022 16:10
@michalkucharczyk michalkucharczyk mentioned this pull request Oct 13, 2022
Merged
@AurevoirXavier AurevoirXavier mentioned this pull request Jan 10, 2023
Closed
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@michalkucharczyk @ark0f
BlockId::Number refactor: trivial changes to BlockId::Hash (paritytec…
201f38f 
…h#12471)

* Trivial BlockId::Number => Hash

* missed BlockId::Hash added
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@dmitry-markin dmitry-markin dmitry-markin approved these changes

@altonen altonen altonen approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
SDK Node
Status: done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michalkucharczyk @bkchr @dmitry-markin @altonen