Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

sp-api: Remove invalid unsafe trait bounds #12502

Merged
merged 2 commits into from
Oct 17, 2022
Merged

sp-api: Remove invalid unsafe trait bounds #12502

merged 2 commits into from
Oct 17, 2022

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Oct 16, 2022

The runtime api implementation contained invalid unsafe trait bounds. Sync was never correct there and Send should have not been "force implemented".

@bkchr
sp-api: Remove invalid unsafe trait bounds
46b6e06 
The runtime api implementation contained invalid unsafe trait bounds. `Sync` was never correct there
and `Send` should have not been "force implemented".
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Oct 16, 2022
@bkchr bkchr requested review from koute and pepyakin October 16, 2022 08:44
@bkchr bkchr requested a review from acatangiu as a code owner October 16, 2022 08:44
ggwpez
ggwpez approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to build the code from the SE question and it now errors with some where C::Api: Sync is missing.
So I assume it is working.

@bkchr
Copy link
Member Author

bkchr commented Oct 16, 2022

I tried to build the code from the SE question and it now errors with some where C::Api: Sync is missing. So I assume it is working.

Exactly :)

koute
koute approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@koute koute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The Sync bound was indeed not correct here.

@bkchr bkchr merged commit 951f075 into master Oct 17, 2022
@bkchr bkchr deleted the bkchr-api-remove-invalid-traits branch October 17, 2022 08:20
@wilwade wilwade mentioned this pull request Oct 17, 2022
Closed
@AurevoirXavier AurevoirXavier mentioned this pull request Jan 10, 2023
Closed
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@bkchr @ark0f
sp-api: Remove invalid unsafe trait bounds (paritytech#12502)
a774746 
The runtime api implementation contained invalid unsafe trait bounds. `Sync` was never correct there
and `Send` should have not been "force implemented".
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@koute koute koute approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@ggwpez ggwpez ggwpez approved these changes

@acatangiu acatangiu acatangiu approved these changes

@pepyakin pepyakin Awaiting requested review from pepyakin

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bkchr @koute @shawntabrizi @ggwpez @acatangiu