This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Run frame_system integrity tests in Externalities
#13092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A0-please_review
ggwpez
changed the title
frame_system integrity tests in Externalities
ggwpez
commented
Jan 6, 2023
| @@ -361,7 +361,9 @@ pub mod pallet { | |||
| #[pallet::hooks] | |||
| impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> { | |||
| fn integrity_test() { | |||
| T::BlockWeights::get().validate().expect("The weights are invalid."); | |||
| sp_io::TestExternalities::default().execute_with(|| { | |||
There was a problem hiding this comment.
Looks like it tries to compile this as no-std when benchmarks are enabled.
This is only a test and should not end up in the runtime, right?
So #[cfg(feature = "std")] should be fine?
bkchr
approved these changes
Jan 7, 2023
kianenigma
approved these changes
Jan 8, 2023
This was also my first thought, but was not sure about unintended consequences and there is not really an advantage. |
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
bot merge |
paritytech-processbot
bot
deleted the
oty-system-integrity-test-externalities
branch
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
* Run frame_system integrity tests in Externalities Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Use feature = 'std' Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Run frame_system integrity tests in Externalities Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Use feature = 'std' Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storageparameter types are currently not usable asBlockWeight, since theintegrity_testofframe_systemruns outside of externalities and therefore fails. This MR just wraps it in externalities to allow that.Having quickly adjustable block PoV weights would be useful for testing the limits on Rococo and Westmint.