Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

remove deprecated remove_prefix to clear era_info #13460

Merged
merged 6 commits into from
May 16, 2023
Merged

remove deprecated remove_prefix to clear era_info #13460

merged 6 commits into from
May 16, 2023

Conversation

surajk-m
Copy link
Contributor

@surajk-m surajk-m commented Feb 24, 2023 •
edited
Loading

This PR removes deprecated remove_prefix to clear era information in Staking Pallet. Fixes #13439

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Feb 24, 2023

User @s5k0651, please sign the CLA here.

@dmitry-markin dmitry-markin added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 7, 2023
@stale
Copy link

stale bot commented Apr 6, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Apr 6, 2023
@surajk-m
Copy link
Contributor Author

surajk-m commented Apr 6, 2023

@kianenigma, Please review the PR.

@stale stale bot removed the A3-stale label Apr 6, 2023
ggwpez
ggwpez approved these changes Apr 11, 2023
View reviewed changes
frame/staking/src/pallet/impls.rs Outdated Show resolved Hide resolved
@surajk-m surajk-m requested a review from a team April 12, 2023 17:48
@stale
Copy link

stale bot commented May 12, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label May 12, 2023
@ggwpez ggwpez removed the request for review from a team May 13, 2023 17:31
@stale stale bot removed the A3-stale label May 13, 2023
@ggwpez ggwpez requested a review from a team May 13, 2023 17:31
@ggwpez
Copy link
Member

ggwpez commented May 13, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented May 13, 2023 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2832043 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 46-ef938d23-daab-448f-90d7-9f2ac53a2d32 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 13, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2832043 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2832043/artifacts/download.

@kianenigma
Copy link
Contributor

bot rebase

@paritytech-processbot
Copy link

Rebased

kianenigma
kianenigma approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your PR description to use github semantic linking, such that the issue you linked gets automatically closed.

@surajk-m surajk-m linked an issue May 16, 2023 that may be closed by this pull request
Stop using deprecated remove_prefix to clear era information in Staking Pallet #13439
Closed
@ggwpez ggwpez added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label May 16, 2023
@ggwpez
Copy link
Member

ggwpez commented May 16, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 8423d2f into paritytech:master May 16, 2023
gpestana pushed a commit that referenced this pull request May 27, 2023
@surajk-m @gpestana
remove deprecated remove_prefix to clear era_info (#13460)
5d796e7 
* remove deprecated remove_prefix to clear era_info

* add debug assertions to check that the returned cursor is None

* add a variable to hold the cursor

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@surajk-m @nathanwhit
remove deprecated remove_prefix to clear era_info (paritytech#13460)
5c2fe95 
* remove deprecated remove_prefix to clear era_info

* add debug assertions to check that the returned cursor is None

* add a variable to hold the cursor

* ".git/.scripts/commands/fmt/fmt.sh"

---------

Co-authored-by: command-bot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@kianenigma kianenigma kianenigma approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop using deprecated remove_prefix to clear era information in Staking Pallet
4 participants
@surajk-m @ggwpez @kianenigma @dmitry-markin