Deprecate `Weight::from_{ref_time, proof_size}` #13475

ggwpez · 2023-02-27T10:59:56Z

Changes:

Deprecate Weight::from_ref_time and Weight::from_proof_size and use from_parts instead
Update weight templates

TODO:

Update weight files
Double-check templates

Polkadot companion: paritytech/polkadot#6794
Cumulus companion: paritytech/cumulus#2245
Migration script for down-stream projects: migrate-from-parts.py.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2023-02-27T11:20:33Z

bot bench $ pallet dev pallet_balances

command-bot · 2023-02-27T11:20:38Z

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2453130 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_balances. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 102-4507782f-6044-45a3-af37-232a5087f28d to cancel this command or bot cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2023-02-27T11:55:20Z

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_balances has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2453130 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2453130/artifacts/download.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

gavofyork · 2023-02-27T23:08:07Z

.maintain/frame-weight-template.hbs

 			{{#each benchmark.component_weight as |cw|}}
 			// Standard Error: {{underscore cw.error}}
-			.saturating_add(Weight::from_ref_time({{underscore cw.slope}}).saturating_mul({{cw.name}}.into()))
+			.saturating_add(Weight::from_parts({{underscore cw.slope}}, 0).saturating_mul({{cw.name}}.into()))


why are we ever using 0 for proof size?

gavofyork · 2023-02-27T23:08:26Z

.maintain/frame-weight-template.hbs

@@ -72,7 +71,7 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
 			.saturating_add(T::DbWeight::get().writes(({{cw.slope}}_u64).saturating_mul({{cw.name}}.into())))
 			{{/each}}
 			{{#each benchmark.component_calculated_proof_size as |cp|}}
-			.saturating_add(Weight::from_proof_size({{cp.slope}}).saturating_mul({{cp.name}}.into()))
+			.saturating_add(Weight::from_parts(0, {{cp.slope}}).saturating_mul({{cp.name}}.into()))


same - why 0 for ref time?

gavofyork · 2023-02-27T23:10:01Z

frame/assets/src/weights.rs

+			.saturating_add(Weight::from_parts(13_799_167, 0).saturating_mul(c.into()))
 			.saturating_add(T::DbWeight::get().reads(2_u64))
 			.saturating_add(T::DbWeight::get().reads((2_u64).saturating_mul(c.into())))
 			.saturating_add(T::DbWeight::get().writes(1_u64))
 			.saturating_add(T::DbWeight::get().writes((2_u64).saturating_mul(c.into())))
-			.saturating_add(Weight::from_proof_size(5180).saturating_mul(c.into()))
+			.saturating_add(Weight::from_parts(0, 5180).saturating_mul(c.into()))


why do these two not just get combined into a single from_parts?

The template is a bit inflexible right now, I can try but it will not look much better. Having these written as a term is very poor choice in retrospect.
Something data-based would be better like https://github.com/paritytech/substrate/issues/12580#issuecomment-1304662025

…t-from

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2023-03-02T21:28:07Z

bot merge

* Deprecate Weight::from_{ref_time, proof_size} Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update templates Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Use from_parts Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Use from_parts Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Dont revert comment 🤦 Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_balances * Update weight files Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * More fixes Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Adapt to Master changes Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: command-bot <>

See paritytech/substrate#13475

* polkadot update to v0.9.42 * remove deprecated trait Store uses See paritytech/substrate#13535 * remove deprecated Weight::from_{ref_time, proof_size} See paritytech/substrate#13475 * allowlist one constant weight See paritytech/substrate#13798 * add new trait associated types * polkadot update to v0.9.42 (xcm) * fixup! remove deprecated trait Store uses * teerex/mock: add missing trait imports * claims/tests: fix benchmark as described in substrate/12951 See: paritytech/substrate#12951 * claims/tests: fix claiming_while_vested_doesnt_work by giving it the existential deposit (ED) Co-authored-by: coax1d <andrewburger1991@gmail.com> --------- Co-authored-by: coax1d <andrewburger1991@gmail.com>

* Deprecate Weight::from_{ref_time, proof_size} Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update templates Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Use from_parts Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Use from_parts Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Dont revert comment 🤦 Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_balances * Update weight files Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * More fixes Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Adapt to Master changes Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: command-bot <>

ggwpez added 5 commits February 26, 2023 19:44

Deprecate Weight::from_{ref_time, proof_size}

bf9882e

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Update templates

e013e30

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Use from_parts

8c4be73

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Use from_parts

bcd5415

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Dont revert comment 🤦

a6be787

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

command-bot added 2 commits February 27, 2023 11:30

Merge branch 'master' of https://github.com/paritytech/substrate into…

6d674f1

… HEAD

".git/.scripts/commands/bench/bench.sh" pallet dev pallet_balances

8f24cca

ggwpez added 2 commits February 27, 2023 13:24

Update weight files

422b685

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

More fixes

991fd01

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez marked this pull request as ready for review February 27, 2023 12:56

ggwpez requested review from kianenigma, athei, acatangiu and andresilva as code owners February 27, 2023 12:56

This was referenced Feb 27, 2023

Migrate to Weight::from_parts paritytech/polkadot#6794

Merged

Migrate to Weight::from_parts paritytech/cumulus#2245

Merged

ggwpez removed the T2-API This PR/Issue is related to APIs. label Feb 27, 2023

gavofyork reviewed Feb 27, 2023

View reviewed changes

gavofyork approved these changes Feb 27, 2023

View reviewed changes

KiChjang approved these changes Mar 2, 2023

View reviewed changes

ggwpez added 2 commits March 2, 2023 12:18

Merge remote-tracking branch 'origin/master' into oty-deprecate-weigh…

3143cb9

…t-from

Adapt to Master changes

9983c41

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

paritytech-processbot bot merged commit 6e81199 into master Mar 2, 2023
4 checks passed

paritytech-processbot bot deleted the oty-deprecate-weight-from branch March 2, 2023 21:28

alistair-singh mentioned this pull request Mar 29, 2023

Use master branches for parity dependencies Snowfork/snowbridge#796

Merged

deepink-mas added a commit to deep-ink-ventures/genesis-dao-node that referenced this pull request Mar 29, 2023

run migration for Weight::from_* (paritytech/substrate#13475)

109555d

ryanleecode mentioned this pull request Mar 30, 2023

fix multisig_pure_proxy_stash.ts paritytech/capi#827

Closed

nazar-pc mentioned this pull request Apr 2, 2023

Update Substrate subspace/subspace#1347

Merged

1 task

kiltbot mentioned this pull request Apr 3, 2023

3️⃣ [AUTOMATIC] Update Polkadot dependencies from 0.9.39 to 0.9.40 KILTprotocol/kilt-node#496

Closed

Alexey-N-Chernyshov mentioned this pull request Apr 5, 2023

Merge trustless-evm-bridge to develop sora-xor/sora2-network#374

Merged

librelois mentioned this pull request Apr 6, 2023

Update substrate/polkadot/cumulus from v0.9.38 to v0.9.40 moonbeam-foundation/moonbeam#2200

Closed

sander2 mentioned this pull request May 18, 2023

chore: upgrade to polkadot 0.9.40 interlay/interbtc#1060

Merged

b-yap mentioned this pull request May 25, 2023

upgrade to polkadot-v0.9.40 pendulum-chain/spacewalk#350

Merged

OverOrion added a commit to OverOrion/pallets that referenced this pull request May 26, 2023

remove deprecated Weight::from_{ref_time, proof_size}

ca889b4

See paritytech/substrate#13475

OverOrion mentioned this pull request May 26, 2023

Polkadot update v0.9.42 integritee-network/pallets#175

Merged

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

ggwpez mentioned this pull request Sep 15, 2023

Disallow usage of from_ref_time for weights after the relevant polkadot version paritytech/polkadot-sdk#1589

Closed

sea212 mentioned this pull request Sep 27, 2023

Update weight templates to reflect weights-v2 zeitgeistpm/zeitgeist#1109

Merged

dmitrylavrenov mentioned this pull request Nov 28, 2023

Tracking issue to bump substrate related deps to polkadot-v0.9.40 humanode-network/humanode#839

Closed

46 tasks

Roznovjak mentioned this pull request Nov 29, 2023

chore: upgrade to polkadot-v1.1.0 galacticcouncil/HydraDX-node#691

Merged

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate `Weight::from_{ref_time, proof_size}` #13475

Deprecate `Weight::from_{ref_time, proof_size}` #13475

ggwpez commented Feb 27, 2023 •

edited

ggwpez commented Feb 27, 2023

command-bot bot commented Feb 27, 2023 •

edited

command-bot bot commented Feb 27, 2023

gavofyork Feb 27, 2023

gavofyork Feb 27, 2023

gavofyork Feb 27, 2023

ggwpez Feb 28, 2023

ggwpez commented Mar 2, 2023

Deprecate Weight::from_{ref_time, proof_size} #13475

Deprecate Weight::from_{ref_time, proof_size} #13475

Conversation

ggwpez commented Feb 27, 2023 • edited

ggwpez commented Feb 27, 2023

command-bot bot commented Feb 27, 2023 • edited

command-bot bot commented Feb 27, 2023

gavofyork Feb 27, 2023

Choose a reason for hiding this comment

gavofyork Feb 27, 2023

Choose a reason for hiding this comment

gavofyork Feb 27, 2023

Choose a reason for hiding this comment

ggwpez Feb 28, 2023

Choose a reason for hiding this comment

ggwpez commented Mar 2, 2023

Deprecate `Weight::from_{ref_time, proof_size}` #13475

Deprecate `Weight::from_{ref_time, proof_size}` #13475

ggwpez commented Feb 27, 2023 •

edited

command-bot bot commented Feb 27, 2023 •

edited