Fix V2 PoV benchmarking #13485

ggwpez · 2023-02-27T21:13:08Z

Changes:

Fix case where Measured was too large for V2 syntax. We currently have some copy&paste code that was wrong in one part. Definitely need to clean it up somehow: 1. item in [FRAME core] ☂ Benchmark syntax V2 follow-ups polkadot-sdk#380.
Besides that the MEL proof size benchmarking uses additional_trie_layers to estimate the number of additional trie layers which have to be accounted for when generating a proof. The default value of 0 only works for extremely small runtimes, which have no more than 16 storage prefices. This is changed to a "sane" default of 2, which is safe for runtimes with up to 4096 storage prefices (eg StorageValue).

The default here only works for extremely small runtimes, which have no more than 16 storage prefices. This is changed to a "sane" default of 2, which is save for runtimes with up to 4096 storage prefices (eg StorageValue). Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2023-02-27T22:01:26Z

bot bench $ pallet dev pallet_balances
bot bench $ pallet dev pallet_message_queue

command-bot · 2023-02-27T22:01:32Z

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2457914 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_balances. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 105-d826761a-068a-49b4-9111-51978f33b5f7 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-02-27T22:01:37Z

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2457915 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_message_queue. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 106-626830cd-9dd7-4e42-9c82-54f2bde72124 to cancel this command or bot cancel to cancel all commands in this pull request.

… HEAD

ggwpez · 2023-02-27T22:10:21Z

bot bench $ pallet dev pallet_glutton

command-bot · 2023-02-27T22:10:26Z

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2457959 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_glutton. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 107-da7bfb84-a4a2-4abb-a331-988eac17772b to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2023-02-27T22:26:22Z

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_balances has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2457914 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2457914/artifacts/download.

command-bot · 2023-02-27T22:50:03Z

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_message_queue has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2457915 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2457915/artifacts/download.

command-bot · 2023-02-27T23:16:59Z

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_glutton has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2457959 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2457959/artifacts/download.

ggwpez · 2023-02-28T10:56:43Z

bot bench $ pallet dev pallet_glutton

command-bot · 2023-02-28T10:56:48Z

@ggwpez https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2460208 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_glutton. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 111-e9aa7e97-6949-45c0-984d-b7494700d584 to cancel this command or bot cancel to cancel all commands in this pull request.

… HEAD

command-bot · 2023-02-28T11:24:38Z

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_glutton has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2460208 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2460208/artifacts/download.

ggwpez · 2023-02-28T11:26:07Z

bot merge

paritytech-processbot · 2023-02-28T11:26:15Z

Waiting for commit status.

paritytech-processbot · 2023-02-28T11:37:03Z

Merge cancelled due to error. Error: Statuses failed for 0ad0395

>0 would also do as a check, but let's try this. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2023-02-28T12:24:45Z

bot merge

paritytech-processbot · 2023-02-28T12:24:53Z

Waiting for commit status.

* Bump default 'additional_trie_layers' to two The default here only works for extremely small runtimes, which have no more than 16 storage prefices. This is changed to a "sane" default of 2, which is save for runtimes with up to 4096 storage prefices (eg StorageValue). Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update tests and test weights Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix PoV weights Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_balances * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_message_queue * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_glutton * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_glutton * Fix sanity check >0 would also do as a check, but let's try this. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: command-bot <>

* Implements dynamic nominations per nominator * Adds SnapshotBounds and ElectionSizeTracker * Changes the ElectionDataProvider interface to receive ElectionBounds as input * Implements get_npos_voters with ElectionBounds * Implements get_npos_targets with ElectionBounds * Adds comments * tests * Truncates nomninations that exceed nominations quota; Old tests passing * Uses DataProviderBounds and ElectionBounds (to continue) * Finishes conversions - tests passing * Refactor staking in babe mocks * Replaces MaxElectableTargets and MaxElectingVoters with ElectionBounds; Adds more tests * Fixes nits; node compiling * bechmarks * removes nomination_quota extrinsic to request the nomination quota * Lazy quota check, ie. at nominate time only * remove non-working test (for now) * tests lazy nominations quota when quota is lower than current number of nominated targets * Adds runtime API and custom RPC call for clients to query the nominations quota for a given balance * removes old rpc * Cosmetic touches * All mocks working * Fixes benchmarking mocks * nits * more tests * renames trait methods * nit * ".git/.scripts/commands/fmt/fmt.sh" * Fix V2 PoV benchmarking (#13485) * Bump default 'additional_trie_layers' to two The default here only works for extremely small runtimes, which have no more than 16 storage prefices. This is changed to a "sane" default of 2, which is save for runtimes with up to 4096 storage prefices (eg StorageValue). Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update tests and test weights Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Fix PoV weights Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_balances * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_message_queue * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_glutton * ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_glutton * Fix sanity check >0 would also do as a check, but let's try this. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: command-bot <> * Move BEEFY code to consensus (#13484) * Move beefy primitives to consensus dir * Move beefy gadget to client consensus folder * Rename beefy crates * chore: move genesis block builder to chain-spec crate. (#13427) * chore: move genesis block builder to block builder crate. * add missing file * chore: move genesis block builder to sc-chain-spec * Update client/chain-spec/src/genesis.rs Co-authored-by: Bastian Köcher <git@kchr.de> * Update test-utils/runtime/src/genesismap.rs Co-authored-by: Bastian Köcher <git@kchr.de> * Update test-utils/runtime/client/src/lib.rs * fix warnings * fix warnings --------- Co-authored-by: Bastian Köcher <git@kchr.de> * Speed up storage iteration from within the runtime (#13479) * Speed up storage iteration from within the runtime * Move the cached iterator into an `Option` * Use `RefCell` in no_std * Simplify the code slightly * Use `Option::replace` * Update doc comment for `next_storage_key_slow` * Make unbounded channels size warning exact (part 1) (#13490) * Replace `futures-channel` with `async-channel` in `out_events` * Apply suggestions from code review Co-authored-by: Koute <koute@users.noreply.github.com> * Also print the backtrace of `send()` call * Switch from `backtrace` crate to `std::backtrace` * Remove outdated `backtrace` dependency * Remove `backtrace` from `Cargo.lock` --------- Co-authored-by: Koute <koute@users.noreply.github.com> * Removal of Prometheus alerting rules deployment in cloud-infra (#13499) * sp-consensus: remove unused error variants (#13495) * Expose `ChargedAmount` (#13488) * Expose `ChargedAmount` * Fix imports * sc-consensus-beefy: fix metrics: use correct names (#13494) Signed-off-by: acatangiu <adrian@parity.io> * clippy fix * removes NominationsQuotaExceeded event * Update frame/staking/src/lib.rs Co-authored-by: Ross Bulat <ross@parity.io> * adds back the npos_max_iter * remove duplicate imports added after merge * fmt * Adds comment in public struct; Refactors CountBound and SizeCount to struct * addresses various pr comments * PR comment reviews * Fixes on-chain election bounds and related code * EPM checks the size of the voter list returned by the data provider * cosmetic changes * updates e2e tests mock * Adds more tests for size tracker and refactors code * Adds back only_iterates_max_2_times_max_allowed_len test * Refactor * removes unecessary dependency * empty commit -- restart all stuck CI jobs * restarts ci jobs * Renames ElectionBounds -> Bounds in benchmarking mocks et al * updates mocks * Update frame/election-provider-support/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Update frame/staking/src/pallet/impls.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Update frame/election-provider-support/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Update frame/staking/src/tests.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * more checks in api_nominations_quota in tests * Improves docs * fixes e2e tests * Uses size_hint rather than mem::size_of in size tracker; Refactor size tracker to own module * nits from reviews * Refactors bounds to own module; improves docs * More tests and docs * fixes docs * Fixes benchmarks * Fixes rust docs * fixes bags-list remote-ext-tests * Simplify bound checks in create_snapshot_external * Adds target size check in get_npos_targets * ".git/.scripts/commands/fmt/fmt.sh" * restart ci * rust doc fixes and cosmetic nits * rollback upgrade on parity-scale-codec version (unecessary) * reset cargo lock, no need to update it --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Signed-off-by: acatangiu <adrian@parity.io> Co-authored-by: command-bot <> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Davide Galassi <davxy@datawok.net> Co-authored-by: yjh <yjh465402634@gmail.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Koute <koute@users.noreply.github.com> Co-authored-by: Dmitry Markin <dmitry@markin.tech> Co-authored-by: Anthony Lazam <lazam@users.noreply.github.com> Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com> Co-authored-by: Piotr Mikołajczyk <piomiko41@gmail.com> Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: Ross Bulat <ross@parity.io> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

ggwpez added 3 commits February 27, 2023 18:11

Update tests and test weights

5b6ad09

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Fix PoV weights

c341d38

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez requested a review from sam0x17 February 27, 2023 21:13

sam0x17 approved these changes Feb 27, 2023

View reviewed changes

ggwpez marked this pull request as ready for review February 27, 2023 21:23

Merge branch 'master' of https://github.com/paritytech/substrate into…

cd79314

… HEAD

".git/.scripts/commands/bench/bench.sh" pallet dev pallet_balances

814c182

".git/.scripts/commands/bench/bench.sh" pallet dev pallet_message_queue

9526efa

gavofyork approved these changes Feb 27, 2023

View reviewed changes

".git/.scripts/commands/bench/bench.sh" pallet dev pallet_glutton

a47df6f

command-bot added 2 commits February 28, 2023 10:56

Merge branch 'master' of https://github.com/paritytech/substrate into…

86843fd

… HEAD

".git/.scripts/commands/bench/bench.sh" pallet dev pallet_glutton

0ad0395

Fix sanity check

022645b

>0 would also do as a check, but let's try this. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

paritytech-processbot bot merged commit 2a7887e into master Feb 28, 2023

paritytech-processbot bot deleted the oty-additional-trie-layers branch February 28, 2023 13:47

kiltbot mentioned this pull request Apr 3, 2023

3️⃣ [AUTOMATIC] Update Polkadot dependencies from 0.9.39 to 0.9.40 KILTprotocol/kilt-node#496

Closed

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

dmitrylavrenov mentioned this pull request Nov 28, 2023

Tracking issue to bump substrate related deps to polkadot-v0.9.40 humanode-network/humanode#839

Closed

46 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix V2 PoV benchmarking #13485

Fix V2 PoV benchmarking #13485

ggwpez commented Feb 27, 2023 •

edited

Loading

ggwpez commented Feb 27, 2023

command-bot bot commented Feb 27, 2023 •

edited

Loading

command-bot bot commented Feb 27, 2023 •

edited

Loading

ggwpez commented Feb 27, 2023

command-bot bot commented Feb 27, 2023 •

edited

Loading

command-bot bot commented Feb 27, 2023

command-bot bot commented Feb 27, 2023

command-bot bot commented Feb 27, 2023

ggwpez commented Feb 28, 2023

command-bot bot commented Feb 28, 2023 •

edited

Loading

command-bot bot commented Feb 28, 2023

ggwpez commented Feb 28, 2023

paritytech-processbot bot commented Feb 28, 2023

paritytech-processbot bot commented Feb 28, 2023

ggwpez commented Feb 28, 2023

paritytech-processbot bot commented Feb 28, 2023

Fix V2 PoV benchmarking #13485

Fix V2 PoV benchmarking #13485

Conversation

ggwpez commented Feb 27, 2023 • edited Loading

ggwpez commented Feb 27, 2023

command-bot bot commented Feb 27, 2023 • edited Loading

command-bot bot commented Feb 27, 2023 • edited Loading

ggwpez commented Feb 27, 2023

command-bot bot commented Feb 27, 2023 • edited Loading

command-bot bot commented Feb 27, 2023

command-bot bot commented Feb 27, 2023

command-bot bot commented Feb 27, 2023

ggwpez commented Feb 28, 2023

command-bot bot commented Feb 28, 2023 • edited Loading

command-bot bot commented Feb 28, 2023

ggwpez commented Feb 28, 2023

paritytech-processbot bot commented Feb 28, 2023

paritytech-processbot bot commented Feb 28, 2023

ggwpez commented Feb 28, 2023

paritytech-processbot bot commented Feb 28, 2023

ggwpez commented Feb 27, 2023 •

edited

Loading

command-bot bot commented Feb 27, 2023 •

edited

Loading

command-bot bot commented Feb 27, 2023 •

edited

Loading

command-bot bot commented Feb 27, 2023 •

edited

Loading

command-bot bot commented Feb 28, 2023 •

edited

Loading