Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Assets pallet: Don't allow set_min_balance when sufficient #13510

Merged
merged 9 commits into from
Mar 3, 2023
Merged

Assets pallet: Don't allow set_min_balance when sufficient #13510

merged 9 commits into from
Mar 3, 2023

Conversation

Szegoo
Copy link
Contributor

@Szegoo Szegoo commented Mar 2, 2023 •
edited
Loading

As mentioned here we shouldn't allow asset owners to decrease the min_balance when the asset is marked as sufficient.

@Szegoo Szegoo changed the title Assets pallet: Don't allow set_min_balance when sufficient Assets pallet: Don't allow set_min_balance when sufficient Mar 2, 2023
@Szegoo
Copy link
Contributor Author

Szegoo commented Mar 2, 2023

cc @jsidorenko @bkchr

IkerAlus
IkerAlus reviewed Mar 2, 2023
View reviewed changes
frame/assets/src/lib.rs Outdated Show resolved Hide resolved
@jsidorenko
Copy link
Contributor

bot bench $ pallet dev pallet_assets

@command-bot
Copy link

command-bot bot commented Mar 2, 2023 •
edited
Loading

@jsidorenko https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2474500 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 15-31e3b96d-31da-4fe7-a776-bbe2ba1b68f8 to cancel this command or bot cancel to cancel all commands in this pull request.

@jsidorenko jsidorenko added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Mar 2, 2023
@command-bot
Copy link

command-bot bot commented Mar 2, 2023

@jsidorenko Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2474500 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2474500/artifacts/download.

bkchr
bkchr approved these changes Mar 2, 2023
View reviewed changes
frame/assets/src/lib.rs Outdated Show resolved Hide resolved
@bkchr
Copy link
Member

bkchr commented Mar 2, 2023

@Szegoo please merge master.

@Szegoo
Copy link
Contributor Author

Szegoo commented Mar 2, 2023

@bkchr Merged. I think we may have to rerun the benchmark.

@jsidorenko
Copy link
Contributor

bot bench $ pallet dev pallet_assets

@command-bot
Copy link

command-bot bot commented Mar 3, 2023 •
edited
Loading

@jsidorenko https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2477663 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/substrate/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 16-e432c0b4-0145-4449-8fdd-fb5dfe1cee5a to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Mar 3, 2023

@jsidorenko Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" pallet dev pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2477663 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2477663/artifacts/download.

@bkchr bkchr merged commit e923511 into paritytech:master Mar 3, 2023
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-40/2468/1

@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
ukint-vs pushed a commit to gear-tech/substrate that referenced this pull request Apr 10, 2023
@Szegoo @bkchr @ukint-vs
Assets pallet: Don't allow set_min_balance when sufficient (parityt…
7598d4e 
…ech#13510)

* Assets pallet: Don't allow set_min_balance when sufficient

* fix

* fix benchmark

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_assets

* Update frame/assets/src/lib.rs

* fix

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_assets

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <git@kchr.de>
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@Szegoo @bkchr @nathanwhit
Assets pallet: Don't allow set_min_balance when sufficient (parityt…
d326d58 
…ech#13510)

* Assets pallet: Don't allow set_min_balance when sufficient

* fix

* fix benchmark

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_assets

* Update frame/assets/src/lib.rs

* fix

* ".git/.scripts/commands/bench/bench.sh" pallet dev pallet_assets

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsidorenko jsidorenko jsidorenko approved these changes

@bkchr bkchr bkchr approved these changes

@IkerAlus IkerAlus IkerAlus approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Szegoo @jsidorenko @bkchr @Polkadot-Forum @IkerAlus