Upgrade to libp2p 0.51.3 #13587

melekes · 2023-03-13T07:34:45Z

Polkadot companion: paritytech/polkadot#7000
Cumulus companion: paritytech/cumulus#2429

melekes · 2023-03-16T09:35:30Z

client/network/src/request_responses.rs

-						)
-					}
+			FromSwarm::DialFailure(e) =>
+				for (p, _) in self.protocols.values_mut() {


this assumes that for every connection we register all protocols. not sure why handler.into_iter() was used before since the logic seems equal in both cases to me

this assumes that for every connection we register all protocols.

Sounds correct

not sure why handler.into_iter() was used before since the logic seems equal in both cases to me

I don't know either but it looks right what has changed here.

At least we don't have ConnectionHandler passed as an argument of DialFailure in libp2p-0.51.2, so I would presume this means the connection failed completely.

melekes · 2023-03-16T10:35:11Z

client/network/src/discovery.rs

 		}

 		{
-			let mut list_to_filter = self.kademlia.addresses_of_peer(peer_id);
+			let mut list_to_filter = self.kademlia.handle_pending_outbound_connection(


should we attempt to get more addresses from kademlia and mdns for a peer if there's no ID (maybe_peer is None)?

Is there easy way to do it? I'd probably not bother with it and just let the next random walk find new peers.

Is there easy way to do it?

the code already does this. no need to do anything.

I was asking if it even makes sense to probe kademlia / mdns if peerID is empty. I guess it won't hurt. Otherwise we can just return empty Vec if maybe_peer.is_none() in the beginning of this function.

I would err on the side of caution and keep the old behavior for now at least.

Addressed in a02f891

paritytech#13587 (comment) fyi: I don't really know what the old behaviour was.

This reverts commit 6544dd4.

melekes · 2023-05-11T14:31:24Z

Don't understand why libp2p-identity fails to compile:

[2023-05-11 11:17:53]     Checking libp2p-identity v0.1.2
[2023-05-11 11:17:53] error[E0599]: no method named `encode_protobuf` found for reference `&PublicKey` in the current scope
[2023-05-11 11:17:53]   --> /cargo_home/registry/src/github.com-1ecc6299db9ec823/libp2p-identity-0.1.2/src/peer_id.rs:69:27
[2023-05-11 11:17:53]    |
[2023-05-11 11:17:53] 69 |         let key_enc = key.encode_protobuf();
[2023-05-11 11:17:53]    |                           ^^^^^^^^^^^^^^^ method not found in `&PublicKey`
[2023-05-11 11:17:53]

encode_protobuf is clearly present...

melekes · 2023-05-11T14:42:49Z

client/network/src/transport.rs

 	};

-	let (transport, bandwidth) = bandwidth::BandwidthLogging::new(transport);
-
-	let authentication_config =


this is the biggest change in 0.51.3 along with deprecating mplex

altonen · 2023-05-11T15:08:48Z

Don't understand why libp2p-identity fails to compile:

[2023-05-11 11:17:53]     Checking libp2p-identity v0.1.2
[2023-05-11 11:17:53] error[E0599]: no method named `encode_protobuf` found for reference `&PublicKey` in the current scope
[2023-05-11 11:17:53]   --> /cargo_home/registry/src/github.com-1ecc6299db9ec823/libp2p-identity-0.1.2/src/peer_id.rs:69:27
[2023-05-11 11:17:53]    |
[2023-05-11 11:17:53] 69 |         let key_enc = key.encode_protobuf();
[2023-05-11 11:17:53]    |                           ^^^^^^^^^^^^^^^ method not found in `&PublicKey`
[2023-05-11 11:17:53]

encode_protobuf is clearly present...

the import for libp2p-identity for sc-consensus is defined as libp2p-identity = { version = "0.1.2", features = ["peerid"] }. If you include ed25519 as a feature, does it work then?

altonen · 2023-05-11T21:02:54Z

It looks like it worked because now it fails in sc-peerset while cargo-check for sc-consensus passed

melekes · 2023-05-12T06:50:45Z

Don't understand why libp2p-identity fails to compile:
[2023-05-11 11:17:53]     Checking libp2p-identity v0.1.2
[2023-05-11 11:17:53] error[E0599]: no method named `encode_protobuf` found for reference `&PublicKey` in the current scope
[2023-05-11 11:17:53]   --> /cargo_home/registry/src/github.com-1ecc6299db9ec823/libp2p-identity-0.1.2/src/peer_id.rs:69:27
[2023-05-11 11:17:53]    |
[2023-05-11 11:17:53] 69 |         let key_enc = key.encode_protobuf();
[2023-05-11 11:17:53]    |                           ^^^^^^^^^^^^^^^ method not found in `&PublicKey`
[2023-05-11 11:17:53] 
encode_protobuf is clearly present...
the import for libp2p-identity for sc-consensus is defined as libp2p-identity = { version = "0.1.2", features = ["peerid"] }. If you include ed25519 as a feature, does it work then?

Yes 🙌 Thanks for your help 🙏

melekes · 2023-05-12T07:12:41Z

bot merge

* client/network: upgrade to libp2p 0.51.0 * make discovery.rs compile * make peer_info.rs compile * changes to notifications and request-response proto * make service.rs compile * towards making request_responses.rs compile * make request_responses.rs compile * make request_responses.rs compile * fix notifications/behaviour.rs tests * fix warnings * remove old code * allow deprecated code (temporary) * upgrade to libp2p 0.51.1 * add TODO for behaviour tests * return empty vec if peer_id is absent #13587 (comment) fyi: I don't really know what the old behaviour was. * update comment to reflect new defaults Closes #13338 * Revert "update comment to reflect new defaults" This reverts commit 7a981ab. * remove config.rs (from wrong merge) * upgrade to libp2p 0.51.2 * fix formatting * use handle_pending_outbound_connection in networt_state RPC * update deps * use re-exports when we use other libp2p packages * Apply suggestions from code review Co-authored-by: Dmitry Markin <dmitry@markin.tech> * format code * handle potential errors in network_state RPC * only update libp2p crate * update libp2p-core * fix docs * use libp2p-identity instead of libp2p where it's possible. libp2p-identity is much smaller, hence makes sense to use it instead of larger libp2p crate. * Update client/network/src/discovery.rs Co-authored-by: Aaro Altonen <48052676+altonen@users.noreply.github.com> * update Cargo.lock * add comment for per_connection_event_buffer_size current value is somewhat arbitrary and needs to be tweaked depending on memory usage and network worker sleep stats. * fix link format * update Cargo.lock * upgrade to libp2p 0.51.3 * deprecate mplex * Revert "deprecate mplex" This reverts commit 9e25820. * Revert "upgrade to libp2p 0.51.3" This reverts commit 6544dd4. * use new libp2p version in `statement` crate * pin version temporarily * libp2p 0.51.3 * deprecate mplex * deprecate legacy noise handshake * fix build error * update libp2p-identity * enable libp2p-identity:ed25519 feature in sc-consensus * enable ed25519 for peerset as well --------- Co-authored-by: Dmitry Markin <dmitry@markin.tech> Co-authored-by: Aaro Altonen <48052676+altonen@users.noreply.github.com> Co-authored-by: parity-processbot <>

* client/network: upgrade to libp2p 0.51.0 * make discovery.rs compile * make peer_info.rs compile * changes to notifications and request-response proto * make service.rs compile * towards making request_responses.rs compile * make request_responses.rs compile * make request_responses.rs compile * fix notifications/behaviour.rs tests * fix warnings * remove old code * allow deprecated code (temporary) * upgrade to libp2p 0.51.1 * add TODO for behaviour tests * return empty vec if peer_id is absent paritytech#13587 (comment) fyi: I don't really know what the old behaviour was. * update comment to reflect new defaults Closes paritytech#13338 * Revert "update comment to reflect new defaults" This reverts commit 7a981ab. * remove config.rs (from wrong merge) * upgrade to libp2p 0.51.2 * fix formatting * use handle_pending_outbound_connection in networt_state RPC * update deps * use re-exports when we use other libp2p packages * Apply suggestions from code review Co-authored-by: Dmitry Markin <dmitry@markin.tech> * format code * handle potential errors in network_state RPC * only update libp2p crate * update libp2p-core * fix docs * use libp2p-identity instead of libp2p where it's possible. libp2p-identity is much smaller, hence makes sense to use it instead of larger libp2p crate. * Update client/network/src/discovery.rs Co-authored-by: Aaro Altonen <48052676+altonen@users.noreply.github.com> * update Cargo.lock * add comment for per_connection_event_buffer_size current value is somewhat arbitrary and needs to be tweaked depending on memory usage and network worker sleep stats. * fix link format * update Cargo.lock * upgrade to libp2p 0.51.3 * deprecate mplex * Revert "deprecate mplex" This reverts commit 9e25820. * Revert "upgrade to libp2p 0.51.3" This reverts commit 6544dd4. * use new libp2p version in `statement` crate * pin version temporarily * libp2p 0.51.3 * deprecate mplex * deprecate legacy noise handshake * fix build error * update libp2p-identity * enable libp2p-identity:ed25519 feature in sc-consensus * enable ed25519 for peerset as well --------- Co-authored-by: Dmitry Markin <dmitry@markin.tech> Co-authored-by: Aaro Altonen <48052676+altonen@users.noreply.github.com> Co-authored-by: parity-processbot <>

client/network: upgrade to libp2p 0.51.0

1f838db

melekes self-assigned this Mar 13, 2023

melekes added 10 commits March 13, 2023 12:20

make discovery.rs compile

a96ec02

make peer_info.rs compile

1feeea5

changes to notifications and request-response proto

7f5bd59

make service.rs compile

6fa1fec

towards making request_responses.rs compile

84fa16e

make request_responses.rs compile

b469184

make request_responses.rs compile

82381e7

fix notifications/behaviour.rs tests

5d47761

fix warnings

683f7d0

remove old code

88faef0

melekes commented Mar 16, 2023

View reviewed changes

allow deprecated code (temporary)

0e4e650

melekes added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 16, 2023

This comment was marked as outdated.

Sign in to view

melekes added the S4-blocked Issue is blocked, see comments for further information. label Mar 17, 2023

melekes added 2 commits March 23, 2023 11:43

upgrade to libp2p 0.51.1

44734ce

add TODO for behaviour tests

38db38c

melekes changed the title ~~client/network: upgrade to libp2p 0.51.0~~ client/network: upgrade to libp2p 0.51.1 Mar 23, 2023

melekes changed the title ~~client/network: upgrade to libp2p 0.51.1~~ Upgrade to libp2p 0.51.1 Mar 23, 2023

melekes marked this pull request as ready for review March 23, 2023 07:48

melekes added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Mar 23, 2023

return empty vec if peer_id is absent

a02f891

paritytech#13587 (comment) fyi: I don't really know what the old behaviour was.

This comment was marked as outdated.

Sign in to view

Merge branch 'master' into anton/13537-upgrade-to-libp2p-0.51.0

dfd5c3e

Revert "upgrade to libp2p 0.51.3"

0bf1bfa

This reverts commit 6544dd4.

melekes changed the title ~~Upgrade to libp2p 0.51.3~~ Upgrade to libp2p 0.51.2 May 4, 2023

melekes added 6 commits May 5, 2023 09:55

Merge branch 'master' into anton/13537-upgrade-to-libp2p-0.51.0

3c69044

use new libp2p version in statement crate

979d076

pin version temporarily

82b3956

Merge branch 'master' into anton/13537-upgrade-to-libp2p-0.51.0

90691b9

libp2p 0.51.3

1c35b82

deprecate mplex

7c7ff40

melekes changed the title ~~Upgrade to libp2p 0.51.2~~ Upgrade to libp2p 0.51.3 May 11, 2023

kpp approved these changes May 11, 2023

View reviewed changes

melekes added 4 commits May 11, 2023 12:56

Merge branch 'master' into anton/13537-upgrade-to-libp2p-0.51.0

bb161c7

deprecate legacy noise handshake

0630e6d

fix build error

5551d23

update libp2p-identity

97e75cf

melekes commented May 11, 2023

View reviewed changes

enable libp2p-identity:ed25519 feature in sc-consensus

a7a5b8e

enable ed25519 for peerset as well

0a0defc

paritytech-processbot bot merged commit 4ce0b74 into paritytech:master May 12, 2023
3 checks passed

melekes deleted the anton/13537-upgrade-to-libp2p-0.51.0 branch May 12, 2023 07:12

nazar-pc mentioned this pull request Jun 16, 2023

Upgrade Substrate (with core-evm-relay removed) subspace/subspace#1549

Merged

1 task

kiltbot mentioned this pull request Jun 21, 2023

1️⃣ [AUTOMATIC] Update Polkadot dependencies from 0.9.42 to 0.9.43 KILTprotocol/kilt-node#531

Closed

kacperzuk-neti mentioned this pull request Jun 23, 2023

Polkadot v0.9.43 liberland/liberland_substrate#295

Merged

15 tasks

jasl mentioned this pull request Jun 30, 2023

Upgrade to Polkadot v0.9.43 Phala-Network/phala-blockchain#1313

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to libp2p 0.51.3 #13587

Upgrade to libp2p 0.51.3 #13587

melekes commented Mar 13, 2023 •

edited

Loading

melekes Mar 16, 2023

altonen Mar 18, 2023

dmitry-markin Apr 3, 2023

melekes Mar 16, 2023

altonen Mar 18, 2023

melekes Mar 20, 2023

altonen Mar 20, 2023

melekes Apr 4, 2023

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

melekes commented May 11, 2023 •

edited

Loading

melekes May 11, 2023

altonen commented May 11, 2023

altonen commented May 11, 2023

melekes commented May 12, 2023

melekes commented May 12, 2023

Upgrade to libp2p 0.51.3 #13587

Upgrade to libp2p 0.51.3 #13587

Conversation

melekes commented Mar 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

melekes commented May 11, 2023 • edited Loading

Choose a reason for hiding this comment

altonen commented May 11, 2023

altonen commented May 11, 2023

melekes commented May 12, 2023

melekes commented May 12, 2023

melekes commented Mar 13, 2023 •

edited

Loading

melekes commented May 11, 2023 •

edited

Loading