This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
FRAME: Fix the Referenda confirming alarm #13704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-please_review
This fails on bf395c8 since the downwards rounding voids the curve delay. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
approved these changes
Mar 25, 2023
2 tasks
gavofyork
changed the title
|
bot merge |
pgherveou
pushed a commit
that referenced
this pull request
Apr 4, 2023
* Fix the Referenda confirming alarm * Add minimal regression test This fails on bf395c8 since the downwards rounding voids the curve delay. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
gpestana
pushed a commit
that referenced
this pull request
Apr 23, 2023
* Fix the Referenda confirming alarm * Add minimal regression test This fails on bf395c8 since the downwards rounding voids the curve delay. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Fix the Referenda confirming alarm * Add minimal regression test This fails on bf395c8 since the downwards rounding voids the curve delay. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were doing a straight
multo get the block number from aPerbill, which will round down if the fractional part is half or less. We should always be rounding up, though, to ensure that when the alarm goes off the confirmation period is definitely ready to begin.It would be good to write a fuzzer to ensure the issue manifested itself prior and no longer manifests after these changes. It is also possible that the issue was fixed by #13660, so if a fuzzer doesn't find this has fixed anything we might want to try testing with the commit immediately before.
Possible fix for paritytech/polkadot-sdk#200