Update the nix build configuration. #13706
Conversation
|
User @farcaller, please sign the CLA here. |
| pkgs = import nixpkgs { inherit system; }; | ||
| in | ||
| { | ||
| devShells.default = pkgs.mkShell { |
There was a problem hiding this comment.
devenv can be used here. it also generates Codespace on demand and more sembles home-manager/nixos config. but this is good too.
There was a problem hiding this comment.
Fixed, thanks! wrong comment
I'll look into it in the next PR if that's alright. I want to add the buildable into the flake as well and it's a bit tricky to do right with a sandbox right now.
|
The |
bkchr
added
A0-please_review
@farcaller please do this and then we can merge this! |
Remove the old shell.nix with some legacy versions pinned and replace it with a flake-based shell. It installs rust via rustup instead of fenix to be more generally compatible with the guidelines. This also adds the rust-toolchain.toml spec with all the components required for wasm, and everything else to make rust-analyzer & clippy happy.
|
@bkchr done. I also added the top-level configuration for substrate as a whole for those who will hack on the project itself (like me) and want the rust-analyzer to work out of the box in nix. |
Do you know if I block this in direnv, it will annoy me every time I open the folder? (I have my own nix files for Substrate etc) |
|
I'm afraid the nagging will be there, yeah. I can make an optional env variable to opt out of that, if it works? My reasoning to have it is that direnv is pretty much the only way for vscode to be friendly with rust-analyzer in complex setups, but I'm not too attache to that commit and can carry it around with me. |
|
Yeah just tested it, could you maybe for now disable it? Or keep the nix file and rename the |
|
Will do. I’ll add .envrc to the ignores too, then. |
|
Updated per comments. |
|
nixification is essential for cross chain contracts and bridges development |
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
bot rebase |
|
Rebased |
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for 07465c6 |
* Update the nix build configuration. Remove the old shell.nix with some legacy versions pinned and replace it with a flake-based shell. It installs rust via rustup instead of fenix to be more generally compatible with the guidelines. This also adds the rust-toolchain.toml spec with all the components required for wasm, and everything else to make rust-analyzer & clippy happy. * Also add the top level flake for hacking on the substrate as whole * Remove the envrc and ignore it instead. * Remove the top-level configuration --------- Co-authored-by: parity-processbot <>
* Update the nix build configuration. Remove the old shell.nix with some legacy versions pinned and replace it with a flake-based shell. It installs rust via rustup instead of fenix to be more generally compatible with the guidelines. This also adds the rust-toolchain.toml spec with all the components required for wasm, and everything else to make rust-analyzer & clippy happy. * Also add the top level flake for hacking on the substrate as whole * Remove the envrc and ignore it instead. * Remove the top-level configuration --------- Co-authored-by: parity-processbot <>
Remove the old shell.nix with some legacy versions pinned and replace it with a flake-based shell. It installs rust via rustup instead of fenix to be more generally compatible with the guidelines.
This also adds the rust-toolchain.toml spec with all the components required for wasm, and everything else to make rust-analyzer & clippy happy.
I verified that
cargo build --releaseworks for the node within the direnv shell created from the flake.✄ -----------------------------------------------------------------------------
Thank you for your Pull Request! 🙏
Before you submit, please check that:
A*for PR status (one required)B*for changelog (one required)C*for release notes (exactly one required)D*for various implications/requirementsFixes #228orRelated #1337.Refer to the contributing guide for details.
After you've read this notice feel free to remove it.
Thank you!
✄ -----------------------------------------------------------------------------