Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[Fix] Bump tuple element number in frame-support. #13760

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

ruseinov
Copy link
Contributor

@ruseinov ruseinov commented Mar 29, 2023

We're currently at the tuple element limit, when we reach that - the runtime compilation fails with a cryptic error. This PR bumps the tuple element number by 50% to ensure nobody hits this.

Details could be found here: https://substrate.stackexchange.com/questions/7212

That is to avoid hitting the pallet limit that emits a cryptic error. More detail could be found here: https://substrate.stackexchange.com/questions/7212 .
@ruseinov ruseinov added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 29, 2023
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also do it in the template node.

@bkchr
Copy link
Member

bkchr commented Mar 29, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 94e97f0

@bkchr
Copy link
Member

bkchr commented Mar 29, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@bkchr
Copy link
Member

bkchr commented Mar 29, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit e217662 into master Mar 29, 2023
@paritytech-processbot paritytech-processbot bot deleted the ruseinov-patch-1 branch March 29, 2023 20:30
@ruseinov
Copy link
Contributor Author

Could also do it in the template node.

No need it seems, there are only a few pallets attached. Now that we have a decent error - it should be more straightforward for others.

pgherveou pushed a commit that referenced this pull request Apr 4, 2023
That is to avoid hitting the pallet limit that emits a cryptic error. More detail could be found here: https://substrate.stackexchange.com/questions/7212 .

Co-authored-by: parity-processbot <>
gpestana pushed a commit that referenced this pull request Apr 23, 2023
That is to avoid hitting the pallet limit that emits a cryptic error. More detail could be found here: https://substrate.stackexchange.com/questions/7212 .

Co-authored-by: parity-processbot <>
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-41-v0-9-42/2828/1

nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
That is to avoid hitting the pallet limit that emits a cryptic error. More detail could be found here: https://substrate.stackexchange.com/questions/7212 .

Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants