Pay tx fee with assets by using the asset conversion pallet #14340

jsidorenko · 2023-06-09T21:15:07Z

Allows to pay for the tx in any assets by swapping it into the native, given the liquidity pool exists

cumulus companion: paritytech/cumulus#2148

frame/transaction-payment/asset-tx-payment/src/lib.rs

frame/transaction-payment/asset-tx-payment/src/payment.rs

frame/transaction-payment/asset-tx-payment/src/tests.rs

Co-authored-by: Squirrel <gilescope@gmail.com>

# Conflicts: # bin/node/runtime/src/impls.rs

frame/transaction-payment/asset-conversion-tx-payment/src/payment.rs

joepetrowski

I think this is OK to go on Westend. Would like to see a few more things addressed before Kusama though. Will let @muharem and/or @kianenigma have another look before approving.

…ent.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

joepetrowski · 2023-06-23T13:24:30Z

How do you benchmark this? How does this effect the base tx weight? How do you ensure the weight is correctly consumed for tx that required conversion vs the one does not require conversion?

This needs to be addressed.

How do you ensure someone doesn't accidentally spend all the funds to perform a swap on a pool with no liquidity?

We don't, this is something that wallets and UIs can (and should) handle.

How do you handle weight refund?

Look at the PR.

Would you handle multi path swap? (because the direct path is not available or low on liquidity or unbalanced)

On Asset Hub we won't need to since everything can only pair with DOT, but this would be a nice addition (and should at least be documented in the README).

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

frame/support/src/traits/tokens/fungibles/regular.rs

kianenigma · 2023-06-23T15:52:34Z

frame/support/src/traits/tokens/fungibles/regular.rs

-	// If successful returns the amount in native tokens.
+/// Trait for providing methods to swap between the chain's native token and other asset classes.
+pub trait SwapNative<Origin, AccountId, Balance, AssetBalance, AssetId> {
+	/// Take an `asset_id` and swap some amount for `amount_out` of the chain's native asset. If an


Do you actually need all of this to be generics, instead of associated types? You can probably save a bunch of boilerplate if you revise.

From what I can seem we want the asset-related stuff to be generic, but everything else to be associated types, because a chain might have multiple asset classes, but almost always has just one native currency. So something like

impl SawpNative<AssetType1> for PalletA {...} impl SawpNative<AssetType2> for PalletB {...}

is reasonable but I don't think we ever want to customize the origin per implementation.

I would invite @gilescope to answer your question :) It was his idea to create this generic

kianenigma

Some suggestions for follow-ups, looks good otherwise.

* Dedup raising swap event * use expect rather than unwrap * Additional checks for future defence. * cargo fmt * Update frame/asset-conversion/src/lib.rs Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com> --------- Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>

jsidorenko · 2023-06-23T19:17:44Z

bot merge

bkchr · 2023-06-24T08:52:23Z

frame/transaction-payment/asset-conversion-tx-payment/src/lib.rs

+		+ From<ChargeAssetLiquidityOf<T>>,
+	ChargeAssetIdOf<T>: Send + Sync,
+{
+	const IDENTIFIER: &'static str = "ChargeAssetTxPayment";


This name should be unique per signed extension. But as I already said on element, we should just make asset-tx-payment generic to support the use case here.

…ch#14340) * Pay tx by swapping the assets * Change liquidity structure * Uncomment the event * Update frame/transaction-payment/asset-tx-payment/src/payment.rs Co-authored-by: Squirrel <gilescope@gmail.com> * New approach * Fix bounds * Clearer version * Change IsType with Into and From * Enable event * Check ED + fix the logic * Add temp comments * Rework the refund * Clean up * Improve readability * Getting closer * fix * Use fungible instead of Currency * Test account without ed * Final push * Fixed * Rename to pallet-asset-conversion-tx-payment * Bring back the old pallet * Update versions * Update docs * Update readme * Wrong readme updated * Revert back doc change * Fix import * Fix kitchensink * Fix * One more time.. * Wait pls * Update frame/asset-conversion/src/lib.rs Co-authored-by: Squirrel <gilescope@gmail.com> * Update frame/support/src/traits/tokens/fungibles/regular.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update docs/comments * Docs improvement * Update frame/transaction-payment/asset-conversion-tx-payment/src/lib.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update frame/transaction-payment/asset-conversion-tx-payment/src/lib.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update frame/transaction-payment/asset-conversion-tx-payment/src/lib.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update frame/transaction-payment/asset-conversion-tx-payment/src/lib.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Update frame/transaction-payment/asset-conversion-tx-payment/src/lib.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Payed -> paid * Docs * Update frame/transaction-payment/asset-conversion-tx-payment/README.md Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com> * Rewrite docs * Try to clean the deps * Add debug assert * Return back frame-benchmarking * Update cargo * Update frame/transaction-payment/asset-conversion-tx-payment/src/mock.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Rename * clearer error message * Docs for Pay by Swap (paritytech#14445) * docs * better error name * more comments * more docs on swap trait * Fix compile errors * Another fix * Refactoring * Update frame/transaction-payment/asset-conversion-tx-payment/src/payment.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * Emit an error if we fail to swap the refund back * Add integrity_test * Update frame/asset-conversion/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Fmt * Use defensive_ok_or * child PR: Tidy swap event (paritytech#14441) * Dedup raising swap event * use expect rather than unwrap * Additional checks for future defence. * cargo fmt * Update frame/asset-conversion/src/lib.rs Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com> --------- Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com> --------- Co-authored-by: Squirrel <gilescope@gmail.com> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Pay tx by swapping the assets

328bbae

jsidorenko requested a review from gilescope June 9, 2023 21:15

gilescope reviewed Jun 10, 2023

View reviewed changes

jsidorenko and others added 3 commits June 12, 2023 18:34

Change liquidity structure

146b611

Uncomment the event

55255be

Update frame/transaction-payment/asset-tx-payment/src/payment.rs

dd329fb

Co-authored-by: Squirrel <gilescope@gmail.com>

jsidorenko added the A3-in_progress Pull request is in progress. No review needed at this stage. label Jun 12, 2023

jsidorenko added 16 commits June 14, 2023 14:22

New approach

589ccbc

Fix bounds

b215921

Clearer version

874e529

Change IsType with Into and From

d4c2cdb

Enable event

7ceb4aa

Check ED + fix the logic

0d3de23

Add temp comments

e6e4060

Rework the refund

74b36fd

Clean up

4b699a9

Improve readability

7d08ec4

Getting closer

8ef5339

fix

2b08707

Use fungible instead of Currency

4b1748a

Test account without ed

3172f2c

Final push

bf807fc

Fixed

5a7aab2

jsidorenko added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jun 16, 2023

jsidorenko added 4 commits June 16, 2023 14:34

Rename to pallet-asset-conversion-tx-payment

fd053d4

Bring back the old pallet

5dab05d

Update versions

b0cb6b5

Merge branch 'master' into js/pay-by-swap

6a87a43

# Conflicts: # bin/node/runtime/src/impls.rs

paritytech-ci requested a review from a team June 23, 2023 13:15

joepetrowski reviewed Jun 23, 2023

View reviewed changes

frame/transaction-payment/asset-conversion-tx-payment/src/payment.rs Outdated Show resolved Hide resolved

paritytech-ci requested a review from a team June 23, 2023 13:16

joepetrowski reviewed Jun 23, 2023

View reviewed changes

frame/transaction-payment/asset-conversion-tx-payment/src/payment.rs Outdated Show resolved Hide resolved

paritytech-ci requested a review from a team June 23, 2023 13:20

joepetrowski reviewed Jun 23, 2023

View reviewed changes

paritytech-ci requested a review from a team June 23, 2023 13:21

Update frame/transaction-payment/asset-conversion-tx-payment/src/paym…

7e763a0

…ent.rs Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

jsidorenko and others added 5 commits June 23, 2023 16:14

Emit an error if we fail to swap the refund back

6beecc3

Add integrity_test

25b201b

Update frame/asset-conversion/src/lib.rs

a211058

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Fmt

f7abdbc

Use defensive_ok_or

63588af

kianenigma reviewed Jun 23, 2023

View reviewed changes

frame/support/src/traits/tokens/fungibles/regular.rs Show resolved Hide resolved

paritytech-ci requested a review from a team June 23, 2023 15:47

kianenigma reviewed Jun 23, 2023

View reviewed changes

paritytech-ci requested a review from a team June 23, 2023 15:52

kianenigma approved these changes Jun 23, 2023

View reviewed changes

gilescope and others added 2 commits June 23, 2023 17:29

Merge branch 'master' into js/pay-by-swap

f191fdf

paritytech-processbot bot merged commit 81d125f into master Jun 23, 2023
44 checks passed

paritytech-processbot bot deleted the js/pay-by-swap branch June 23, 2023 19:17

bkchr reviewed Jun 24, 2023

View reviewed changes

This was referenced Aug 24, 2023

Asset Conversion LPFee Should Use a Per{Something} Instead of u32 paritytech/polkadot-sdk#88

Open

Asset Conversion Roadmap paritytech/roadmap#33

Open

redzsina added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Jul 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pay tx fee with assets by using the asset conversion pallet #14340

Pay tx fee with assets by using the asset conversion pallet #14340

jsidorenko commented Jun 9, 2023 •

edited by gilescope

joepetrowski left a comment

joepetrowski commented Jun 23, 2023

kianenigma Jun 23, 2023

jsidorenko Jun 23, 2023

kianenigma left a comment

jsidorenko commented Jun 23, 2023

bkchr Jun 24, 2023

Pay tx fee with assets by using the asset conversion pallet #14340

Pay tx fee with assets by using the asset conversion pallet #14340

Conversation

jsidorenko commented Jun 9, 2023 • edited by gilescope

joepetrowski left a comment

Choose a reason for hiding this comment

joepetrowski commented Jun 23, 2023

kianenigma Jun 23, 2023

Choose a reason for hiding this comment

jsidorenko Jun 23, 2023

Choose a reason for hiding this comment

kianenigma left a comment

Choose a reason for hiding this comment

jsidorenko commented Jun 23, 2023

bkchr Jun 24, 2023

Choose a reason for hiding this comment

jsidorenko commented Jun 9, 2023 •

edited by gilescope