This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Report the average network bandwidth #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Jan 24, 2019
core/cli/src/informant.rs
Outdated
| struct TransferRateFormat(u64); | ||
| impl fmt::Display for TransferRateFormat { | ||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
| // We special case 0. |
| Ok(Async::Ready(Some((BandwidthFuture { | ||
| inner, | ||
| sinks: self.sinks.clone(), | ||
| }, addr)))) |
| } | ||
|
|
||
| impl<TInner> tokio_io::AsyncRead for BandwidthConnecLogging<TInner> | ||
| where TInner: tokio_io::AsyncRead |
| } | ||
|
|
||
| impl<TInner> Write for BandwidthConnecLogging<TInner> | ||
| where TInner: Write |
andresilva
pushed a commit
that referenced
this pull request
Jan 31, 2019
* Report the average network bandwidth * Fix concerns
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
* Report the average network bandwidth * Fix concerns
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1545
The file
core/network-libp2p/src/transport/bandwidth.rsshould eventually be moved to libp2p, but since libp2p master contains breaking changes, it would have been painful to integrate in Substrate on a short time frame.We also now send
bandwidth_downloadandbandwidth_uploadto the telemetry (an integer containing the number of bytes per second), but the telemetry server doesn't interpret them.Here is a picture: