This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fixed panic handling #1667
Merged
Fixed panic handling #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkpar
force-pushed
the
a-fix-call-panic
branch
from
2b139a4
to
de42caf
Compare
bkchr
approved these changes
Feb 3, 2019
| ")} | ||
|
|
||
| /// Set aborting flag. Returns previous value of the flag. | ||
| pub fn set_abort(enabled: bool) -> bool { |
There was a problem hiding this comment.
I think this function should not be public?
There was a problem hiding this comment.
panics in the runtime should not abort, but panics in client code, including exernalities, should.
There was a problem hiding this comment.
@bkchr I'd leave it public in case someone needs to set and forget. The crate API aims to be universal.
bkchr
reviewed
Feb 3, 2019
| @@ -181,35 +181,41 @@ where | |||
| H::Out: Ord + HeapSizeOf, | |||
| { | |||
| fn storage(&self, key: &[u8]) -> Option<Vec<u8>> { | |||
| let _guard = panic_handler::AbortGuard::new(true); | |||
There was a problem hiding this comment.
As @rphmeier answered in the wrong comment, client code panic should not lead to runtime error and potential consensus issues. Also panic behaviour between native and wasm runtimes needs to be consistent.
bkchr
added
A8-looksgood
and removed
A0-please_review
gavofyork
pushed a commit
that referenced
this pull request
Feb 4, 2019
* Link substrate issue tracker in panic * Replace allocator with freeing-bump allocator * Revert me: Panic on double allocate/free * Revert me: Add shallow benchmark for a first impression * Revert "Revert me: Add shallow benchmark for a first impression" This reverts commit 5f0d4df. * Revert "Revert me: Panic on double allocate/free" This reverts commit a114df7. * Rename heap to FreeingBumpHeapAllocator * Rename heap.rs to allocator.rs * Use sandbox heap * Move functions * Move variables into constructor * Revert "Move variables into constructor" This reverts commit f46fa0d. * Remove unnecessary casts * Add comment for new parameter * Improve typing * Move variables into constructor * Avoid dynamic allocation * Remove unused variables * Revert "Link substrate issue tracker in panic" This reverts commit 32dfa1d. In the meantime this was fixed in #1667. * Improve naming * Only assert in debug mode * Remove dynamic allocation
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
* Link substrate issue tracker in panic * Replace allocator with freeing-bump allocator * Revert me: Panic on double allocate/free * Revert me: Add shallow benchmark for a first impression * Revert "Revert me: Add shallow benchmark for a first impression" This reverts commit 5f0d4df. * Revert "Revert me: Panic on double allocate/free" This reverts commit a114df7. * Rename heap to FreeingBumpHeapAllocator * Rename heap.rs to allocator.rs * Use sandbox heap * Move functions * Move variables into constructor * Revert "Move variables into constructor" This reverts commit f46fa0d. * Remove unnecessary casts * Add comment for new parameter * Improve typing * Move variables into constructor * Avoid dynamic allocation * Remove unused variables * Revert "Link substrate issue tracker in panic" This reverts commit 32dfa1d. In the meantime this was fixed in paritytech#1667. * Improve naming * Only assert in debug mode * Remove dynamic allocation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1470