This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use from_ss58check and to_ss58check from Ss58Codec for ed25519 #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
approved these changes
Apr 24, 2019
bkchr
reviewed
Apr 24, 2019
| @@ -92,7 +92,7 @@ fn grandpa_observer<B, E, Block: BlockT<Hash=H256>, RA, S>( | |||
|
|
|||
| // if the commit we've received targets a block lower than the last | |||
| // finalized, ignore it and continue with the current state | |||
| if commit.target_number < last_finalized_number { | |||
| if commit.target_number <= last_finalized_number { | |||
There was a problem hiding this comment.
That looks like some different fix hiding in this pr. I think we should move this into a new pr + add a test for it.
There was a problem hiding this comment.
Yeah, I was just testing as the commit name was trying to suggest (it was getting stuck in some grandpa tests).
marcio-diaz
force-pushed
the
marcio/fix-conflict-ss58check
branch
from
bfb2fba
to
1e871d1
Compare
thiolliere
pushed a commit
that referenced
this pull request
May 31, 2019
gavofyork
pushed a commit
that referenced
this pull request
Jun 4, 2019
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Jul 10, 2019
…ytech#2355) * fix: use Ss58Codec for from_ss58check and to_ss58check * Update lib.rs * chore: clean
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #2332