Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

git: allow diffing Cargo.lock #2370

Merged
merged 1 commit into from Apr 24, 2019
Merged

git: allow diffing Cargo.lock #2370

merged 1 commit into from Apr 24, 2019

Conversation

andresilva
Copy link
Member

I don't know why this was done but my editor respects this and I have to edit it out every time I want to diff the Cargo.lock.

@andresilva andresilva added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Apr 24, 2019
bkchr
bkchr approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are my hero! I never understood why git said that this file is a binary file.

@bkchr bkchr merged commit ba16f60 into master Apr 24, 2019
@bkchr bkchr deleted the andre/diff-cargo-lock branch April 24, 2019 15:54
MTDK1 pushed a commit to bdevux/substrate that referenced this pull request Jul 10, 2019
@andresilva @MTDK1
git: allow diffing Cargo.lock (paritytech#2370)
af3dfa3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andresilva @bkchr