This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Signed transactions now have affinity with runtime versions #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
changed the title
andresilva
approved these changes
Aug 18, 2019
|
CC @jacogr |
This was referenced Aug 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically just ensures that transactions (or rather their signature) are linked to the runtime version for which they were intended. It will mean that signed transactions submitted before a runtime upgrade will need to be resubmitted if they don't get included prior to the runtime upgrade going through.
This is important since a runtime upgrade can alter the meaning of a transaction and we don't want a transaction signed for one purpose doing something else when finally executed.
It could have been done by adding a generic param
Get<RuntimeVersion>to theCheckVersionstruct, rather than as an associated type of thesystem::Trait, however I figure having the runtime version available to the system trait will probably be a useful thing to have in the future.