This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Decouple randomness-collective-flip #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
requested review from
jimpo,
kianenigma,
pepyakin and
thiolliere
as code owners
kianenigma
reviewed
Oct 10, 2019
kianenigma
reviewed
Oct 10, 2019
kianenigma
reviewed
Oct 10, 2019
bkchr
approved these changes
Oct 10, 2019
| @@ -33,7 +33,7 @@ pub use sr_primitives::BuildStorage; | |||
| pub use timestamp::Call as TimestampCall; | |||
| pub use balances::Call as BalancesCall; | |||
| pub use sr_primitives::{Permill, Perbill}; | |||
| pub use support::{StorageValue, construct_runtime, parameter_types}; | |||
| pub use support::{StorageValue, construct_runtime, parameter_types, traits::Randomness}; | |||
There was a problem hiding this comment.
Otherwise have this error
error[E0599]: no function or associated item named `random_seed` found for type `srml_randomness_collective_flip::Module<Runtime>` in the current scope
--> node/runtime/src/lib.rs:594:30
|
594 | RandomnessCollectiveFlip::random_seed()
| ^^^^^^^^^^^ function or associated item not found in `srml_randomness_collective_flip::Module<Runtime>`
|
= help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope, perhaps add a `use` for it:
| @@ -22,7 +22,7 @@ | |||
|
|
|||
| use rstd::prelude::*; | |||
| use support::{ | |||
| construct_runtime, parameter_types, traits::{SplitTwoWays, Currency} | |||
| construct_runtime, parameter_types, traits::{SplitTwoWays, Currency, Randomness} | |||
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com> Co-Authored-By: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
|
@kianenigma No there isn't previous discussion about this. Just me want to write some code that doesn't involve too much thinking. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple randomness-collective-flip and other modules