This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Publish the dispatch info in extrinsic events #4148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Place the DispatchInfo (which contains weight information about the extrinsic that is otherwise difficult to determine) in the dispatch result value.
kianenigma
approved these changes
Nov 19, 2019
|
afaik the RPC is useful only for extrinsics that have yet to happen, not that have happened. |
|
100%, the RPC is pre-execution, the events are post-execution. So the events are especially useful in explorers that display historical transactions with all associated info, where the RPC is especially useful in wallets where transactions are made. |
|
The request came from me (for Polkascan). There seems no other way to accurately determine fees on transaction level for historical transactions. We should be able to determine the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place the DispatchInfo (which contains weight information about the
extrinsic that is otherwise difficult to determine) in the dispatch
result value.
CC @jacogr