This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Including runners-up in check for defunct phragmen voter. #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @jnaviask signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
bkchr
reviewed
Dec 10, 2019
jnaviask
force-pushed
the
jnaviask.defunct-fix
branch
from
f7f7b61
to
ee4379c
Compare
bkchr
approved these changes
Dec 10, 2019
|
CC @kianenigma |
|
Thanks @jnaviask! +1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
is_defunct_voterfunction is intended to check whether all of a given voter's selections are invalid. A selection is valid if it is a candidate in the next round, i.e. if it is a current member or runner-up (and thus automatically added as candidates), or on the candidates list.However, the function as implemented did not check for runners-up. This PR adds this check to fix the bug, which would have permitted incorrect reports of defunct voters if they only voted for current runners-up. This PR also expands the
can_detect_defunct_votertest case to catch the bug.