This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
grandpa: filter some telemetry events on larger voter sets #4700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GRANDPA client sends telemetry events upon receiving a new vote or commit. These events are then used to produce a visualization of the round state. With a high number of authorities, say 150, every node will be sending ~300 telemetry events per round, for a total of ~45000 events. Currently on the Kusama network, a round usually takes less than a second to complete. @arkpar mentioned that formatting of these telemetry events showed up in the memory profiler. With a validator set of that size the visualization UI is also unusable, therefore we will filter sending these telemetry events if the validator set size is bigger than 10.