Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Export GRANDPA AuthorityPair when full_crypto is enabled #4872

Merged
merged 2 commits into from Feb 10, 2020

Conversation

h4x3rotab
Copy link
Contributor

Exporting GRANDPA AuthorityPair can make it easier to build a light client in Intel SGX (no_std) environment.

This PR is a re-open of #4869. In the previous PR I forgot to add the AuthorityPair change.

@parity-cla-bot
Copy link

It looks like @h4x3rotab signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@h4x3rotab h4x3rotab requested a review from bkchr February 10, 2020 08:06
@bkchr
Copy link
Member

bkchr commented Feb 10, 2020

Will you only need this for Grandpa? Or also for Babe or similar?

@h4x3rotab
Copy link
Contributor Author

Good point. Right now Grandpa is the only one I'm using but I may need it for other consensus modules as well. Do you think I should change them at once?

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it is okay for now. I have some idea to unify this exporting.

@bkchr bkchr merged commit 19b67cd into paritytech:master Feb 10, 2020
@h4x3rotab
Copy link
Contributor Author

Thanks!

@h4x3rotab h4x3rotab deleted the grandpa-full-crypto branch February 10, 2020 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants